remove theme_comment_block();
add template_preprocess_comment_block();
create comment-block.twig for Startk theme

*edit* Please please please DO NOT REMOVE THEME FUNCTIONS. It will break everything other than the Stark theme.

CommentFileSizeAuthor
#13 refactoring_theme_comment_block-1779146-12.patch461 bytesvlad.dancer
#10 refactoring_theme_comment_block-1779146-10.patch598 bytesvlad.dancer
#4 1779146-refactoring_comment_block-4.patch1.95 KBpodarok
#1 1779146-comment-block.patch1.97 KBMadFish
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MadFish’s picture

MadFish CreditAttribution: MadFish commented
FileSize
1779146-comment-block.patch1.97 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

looks good!
thanks

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/themes/stark/templates/comment/comment-block.twig
@@ -0,0 +1,9 @@
+{{ content }}
\ No newline at end of file

Require crlf at the end of the file

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
FileSize
1779146-refactoring_comment_block-4.patch1.95 KB

fixed #3
commited #1

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs work » Fixed
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Component: Code » Twig templates

commited into 8.x branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Closed (fixed) » Needs work

Reopened due to not having been merged to front-end branch.

*DO NOT RENAME theme_ functions for now*

Needs re-roll.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer commented
Assigned: MadFish » vlad.dancer
Status: Needs work » Active
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer commented
Status: Active » Needs review
Issue tags: +Documentation
FileSize
refactoring_theme_comment_block-1779146-10.patch598 bytes

Just checked, patch already in front-end branch.
Don't forget close issues if it marked as fixed in "Core theme functions" g.docs!
But i did some func. doc changes + renamed preprocess func. Need review

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Assigned: vlad.dancer » psynaptic

I thought template_ was correct for the very first implementation?

@psynaptic: Can you have a look?

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented

#10 make sense for me
Workaround used for comment module only, why template_ ?

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer commented
Assigned: psynaptic » Unassigned
FileSize
refactoring_theme_comment_block-1779146-12.patch461 bytes

It seems to be we using template_preprocess for initial adding variables, so below is my patch just with doc block update.

merdekiti’s picture

merdekiti CreditAttribution: merdekiti commented
Status: Needs review » Reviewed & tested by the community
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Fixed

#13 commited / push to front-end

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

added desperate plea for help