Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
convert core/modules/field/field.module theme_field() to twig
Comment | File | Size | Author |
---|---|---|---|
#10 | 1779034-field10.patch | 3.1 KB | shlapa |
#5 | 1779034-field5.patch | 3.01 KB | shlapa |
#3 | 1779034-field1.patch | 1.7 KB | shlapa |
#1 | 1779034-field.patch | 1.7 KB | shlapa |
Comments
Comment #1
shlapa CreditAttribution: shlapa commentedComment #2
podarokwrong diff
Comment #3
shlapa CreditAttribution: shlapa commentedcorrected patch
Comment #4
podarokno tabs - use whitespaces
No newline at end of file
Comment #5
shlapa CreditAttribution: shlapa commentedfixes after code review
Comment #6
shlapa CreditAttribution: shlapa commentedComment #7
podarokbetter not use restyling in patches
but I think we can RTBC here
all other code looks good
Comment #8
andypostSuppose attributes are unified in http://drupal.org/node/1727592 and probably this branch a bit outdated
Also related #1623574: Remove trailing space from form element labels and field labels (HTML nbsp)
Comment #9
podarokpostponed till #1779136: Weekly - Merge Twig sandbox with latest HEAD
Comment #10
shlapa CreditAttribution: shlapa commentedfinal version for now...
most of variables are already Attributes objects, except mentioned as FIXME in patch.
trailing space removed
Comment #11
podaroklooks good for me
waiting for #1779136: Weekly - Merge Twig sandbox with latest HEAD
Comment #12
podarokdue to #1779136: Weekly - Merge Twig sandbox with latest HEAD
need reroll
Comment #13
podarokcommited #10 to 8.x branch
Comment #14
podarokstatus
Comment #16
Fabianx CreditAttribution: Fabianx commentedReopened due to not having been merged correctly to front-end branch.
Needs re-roll.
Comment #17
oseldman CreditAttribution: oseldman commentedPatch from #10 applied cleanly, but field.html.twig had already been placed properly in the directory. I committed the changes to field.module.