Should be core/themes/stark/templates/user/user-permission-description.twig

Original theme_user_permission_description()

CommentFileSizeAuthor
#2 1778912-user-permission-description-2.patch3.21 KBandypost
#1 1778912-user-permission-description-1.patch1.27 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
1778912-user-permission-description-1.patch1.27 KB

Not sure about doc-block formatting

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
1778912-user-permission-description-2.patch3.21 KB

Fixed theme_user()

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +code sprint drupal night ua 2012

looks good
good example for function to twig template conversion

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Fixed

commited
thanks

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Issue tags: +documentation guide, +Twig

feel free update docs with this nice example conversion

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Component: Code » Twig templates

commited into 8.x branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Closed (fixed) » Needs work

Reopened due to not having been merged to front-end branch.

DO NOT REMOVE theme_ functions for now

Needs re-roll.

tlattimore’s picture

tlattimore CreditAttribution: tlattimore commented
Status: Needs work » Closed (fixed)

I don't think there is anything here that needs a re-roll. Since theme_functions do not need removal yet, and /core/themes/stark/templates/user/user-permission-description.twig exists in the fron-end branch. Marking as closed & someone can reopen if I'm wrong.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Closed (fixed) » Needs work 
+++ b/core/modules/user/user.moduleundefined
@@ -129,7 +129,7 @@ function user_theme() {
     'user_permission_description' => array(
       'variables' => array('permission_item' => NULL, 'hide' => NULL),
-      'file' => 'user.admin.inc',
+      'template' => 'user-permission-description',
     ),

Should not remove file, but still add the template part.

Re-opening.

tlattimore’s picture

tlattimore CreditAttribution: tlattimore commented
Status: Needs work » Needs review

Committed the template reference fabianx outlined in #10 here: http://drupalcode.org/sandbox/pixelmord/1750250.git/commitdiff/c4e7244d9...

Don't think that it will be an issue, but going to tag for review since I didn't roll a patch first. If there's a problem with it we can roll back the commit.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs review » Fixed

Works for me. That is fixed then.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.