Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Currently, jQuery is a dependency in intercom.js
and provided through intercom.libraries.yml
.
Problem:
Some sites do not use jQuery, and this module adds it, affecting performance.
Solution:
As Intercom is not dependent on jQuery to work, we should remove jQuery for those sites that would not like to include it.
Patch incoming.
Comment | File | Size | Author |
---|---|---|---|
#5 | remove_jquery.patch | 640 bytes | hotpizzas |
#2 | remove_jquery.patch | 621 bytes | hotpizzas |
Comments
Comment #2
hotpizzas CreditAttribution: hotpizzas as a volunteer and at Chromatic commentedHere's the patch
Comment #3
markdorisonComment #4
markdorisonWhen anonymous I am seeing the following error in the console:
ReferenceError: Drupal is not defined
on line 22 of intercom.jsComment #5
hotpizzas CreditAttribution: hotpizzas as a volunteer and at Chromatic commentedThis should work. Tested anonymous in Chrome
Comment #6
hotpizzas CreditAttribution: hotpizzas as a volunteer and at Chromatic commentedComment #7
markdorisonWorks as expected in my testing.
Comment #9
jaapjan CreditAttribution: jaapjan as a volunteer and at Open Social commentedThanks, good catch! Will be in the 1.1 release later.
Comment #10
jaapjan CreditAttribution: jaapjan as a volunteer and at Open Social commented