The install_menu_create_url_alias() is a general function and really doesn't have anything to tie it strictly to the menu system, it should be named install_create_url_alias() or install_add_url_alias() and moved to system.inc.

CommentFileSizeAuthor
#1 install_profile_api-n412056-url_alias.patch1.82 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
install_profile_api-n412056-url_alias.patch1.82 KB

Patch attached that renames the function to install_add_url_alias to match the other CRUD functions, and moves it to core/system.inc.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review

Can has review? ^_^ (i.e. I forgot to change the status when I submitted the last comment)

James Andres’s picture

James Andres CreditAttribution: James Andres commented

I'm onboard. But I feel a bit uneasy breaking API's without community feedback.

Thoughts? dww, Boris, webchick .. etc?