Upgrade from filefield_insert fails

Hm strange. It looks like it might be available some of the time (such as if the caches are empty). But I think you're right, we should be pulling in that include directly. Committed the attached patch.

I did a CVS checkout of your project with the applied patch just a few minutes ago. I saw that "filefield_insert_settings" was in my Devel Variable Editor -- but upon upgrade to Insert I got:
"Invalid foreach called in insert.install line 24"

It said that the upgrade occurred, and deactivated filefield_insert module -- but my "file insert" widgets have not been updated to reflect the widget depicted on: http://drupal.org/node/610286

I will look at the code more later ....

EDIT: I did do a Devel "Flush all caches" after I installed and ran update.php ...

Alright looks like I introduced a new bug in my last "fix". The && operator takes precedence over the = operator, meaning that we were essentially setting $filefield_insert_settings = 1, which would cause the foreach() error. This version wraps in parentheses and correctly disables FileField Insert by using module_disable() instead of drupal_uninstall_module(). Since FileField Insert didn't have an uninstall hook, there's not much difference in just disabling it instead of uninstalling.

Thanks again Wim for your testing, please let me know if it's still broken.

I get this error when I use drush (drush enable insert), but it works ok enabling from within drupal (using version 6.x-1.0-beta1 unpatched).

I'll try it with the patch when I have a sec.

You don't need to use the patch, just try out the beta2 version.