Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The idea dates back to the module's D6 version: #470366: Work with other CCK fields besides FileField/ImageField (Node Reference, Text, Emfield, etc), but was never really pursued in depth. I was not sure whether implementing such an interface is feasible without extremely extending the code base, but I think it is a great idea, so I had a go on that regarding Insert for D8. I thought about things like inserting maps directly into the editor, or just any kind of predefined HTML structure that is to be filled with field values. This also opens up Insert for individual module solutions in custom Drupal installations.
A patch set is attached. It increases the number of hooks invoked by Insert and shuffles some code. Yet, the overall change is on a relatively moderate level.
Existing tests are passing, the change might still need some code clean-up though. Anyway, it would be great, if someone had a short manual test run on that. The patch set contains a proof-of-concept module "insert_text", which will not be part of the final change. It is just there to proof the interface implementation for the simple text field. As to the concept of Insert, at least one style needs to be activated on a field to activate Insert. That is the reason, why a custom style is implemented in "insert_text".
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | insert-2994066-interface-3.patch | 54.97 KB | Snater |
| #4 | insert-2994066-interface-2.patch | 52.72 KB | Snater |
| #3 | insert-2994066-interface.patch | 50.98 KB | Snater |
| insert-interface.patch | 48.68 KB | Snater |
Comments
Comment #2
Snater CreditAttribution: Snater commentedComment #3
Snater CreditAttribution: Snater commentedAnother patch set on that, since I had some time. Tests pass. I am going to take another look at the change during the next couple of days and plan to submit it within the next two weeks. Because it shovels around quite some code, I regard it a blocker for all other changes. So nothing will move on until this issue is solved. While there is quite some structural change, it should not cause any breakage just using the module. It's just that hook_insert_aggregate_variables is removed/replaced. There will be a lot more hooks invoked by Insert with this change, allowing other modules to interface to Insert to a quite broad extent.
Comment #4
Snater CreditAttribution: Snater commentedMoved the placeholder definitions to JavaScript, because there is no need to just shovel them around in PHP and the placeholder replacement logic is part of JS anyway.
Comment #5
Snater CreditAttribution: Snater commentedOne hook less.
Comment #7
Snater CreditAttribution: Snater commented