The module is missing the settings migration. Please add it.

CommentFileSizeAuthor
#6 insert-2925143-D7-migration.patch5.38 KBSnater
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass created an issue. See original summary.

hass’s picture

Title: Add migration from D7/D6 » Add migration from D6/D7 to D8
Snater’s picture

Implementing migration of the module settings from D7 to D8 is a valid request. Yet, it is a quite cumbersome task for a rather limited benefit. The D7 field instance settings provided by the Insert module would need to be migrated to D8 field widget display options and the Insert File/Image widget would need to be activated. It would be awesome if there was some module that has already done something similar.
The module's Drupal 6 version is not supported anymore. Migration from Drupal 6 is unlikely to get implemented.

hass’s picture

I cannot check every setting in my site on a migration. I simply expect that my migrated site works as before and features are not getting lost or require rethinking of everything. A migration need to be smooth and complete without data / settings loss.

I do not care about D6 myself, but this should be a 5 minutes task once D7 is done. If D6 is still supported or not - does not matter. It only shows maintainers are behind. I‘m sure people on D6 still like to migrate without settings loss, too. If we always wait long enough we can say this everytime and people stand in the rain with migration.

Snater’s picture

It is not that your request is invalid. Yet, the conceptual changes from D7 to D8 are very fundamental. I did create neither the D6, nor the D7 version of the Insert module, the D8 version is a complete re-write.
As far as I am aware, the D7 to D8 migration routine is utterly complex for non-standard tasks like that. Yet, I plan to take a deeper look into that. Until then, in terms of Open Source, you are welcome to contribute to solving the issue instead of blaming maintainers contributing code in their spare time.

Snater’s picture

Title: Add migration from D6/D7 to D8 » Add migration from D7 to D8
Version: 8.x-1.x-dev » 8.x-2.x-dev
Assigned: Unassigned » Snater
Priority: Major » Normal
Status: Active » Needs review
FileSize
5.38 KB

In version 8.x-2.x of the Insert module, Insert's widgets inheriting from core's image/file widgets are removed with widget settings being attached directly to the core widgets. That removes quite some complexity from the module code.

Nonetheless, it took me more than a day's work to figure out how to migrate the Insert widget settings from Drupal 7 to Drupal 8. Not sure whether that is the proper way (migration documentation is lacking in respect to that task), but it seems to do the job.

It would be very good if a lot of people would test if the migration functionality does not interfere with anything. I will wait some time with uploading the change into the repository.

  • Snater committed 6ece056 on 8.x-2.x
    Issue #2925143: Migration from D7 to D8
    
Snater’s picture

Put into 8.x-2.x development branch.

Snater’s picture

Status: Needs review » Fixed
Parent issue: » #2981038: Release 8.x-2.0

As no one else has verified the ticket by now, I have tested it again by myself.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.