Insert module doesn't work with Drupal 7.20 [#1923336]

Comment	File	Size	Author
#22	setup_filter.png	116.61 KB	pp
#21	1923336-13.patch	957 bytes	pp
#8	1923336.patch	854 bytes	pp

Comment #1

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 12:23

Status:

Active

» Closed (works as designed)

I have old links from my production env, works as designed and closed. Sorry.

Log in or register to post comments

Comment #2

Ben Young CreditAttribution: Ben Young commented 21 February 2013 at 15:54

Status:

Closed (works as designed)

» Active

I disagree with this being closed. Insert fails to generate an image using an image style for me since Drupal 7.20.

Log in or register to post comments

Comment #3

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 15:54

Status:

Active

» Needs review

I have update my links on stag env, but some links are broken yet. It seems that image styles inserted with insert module hasn't been created. Does anyone have similar poblem?

Log in or register to post comments

Comment #4

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 15:55

Status:

Needs review

» Active

Log in or register to post comments

Comment #5

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 15:55

Thanks for quick replay. I was thinking it is only my problem.

Log in or register to post comments

Comment #6

Olafski

Hamburg

CreditAttribution: Olafski commented 21 February 2013 at 16:01

On my site, some of the image styles work with "Insert", others don't. Didn't figure out yet, why.

Log in or register to post comments

Comment #7

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 16:05

Olafski, for some images you have image's styles generated by other modules perhaps, as I have.

Log in or register to post comments

Comment #8

pp CreditAttribution: pp commented 21 February 2013 at 16:12

Status:

Active

» Needs review

File	Size
1923336.patch	854 bytes

This patch resolve this issue.

Please review.

Log in or register to post comments

Comment #9

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 17:03

Yes, it works, but overall I have to use absolute paths to see images after save a node. With relative paths I can only see images in wyswigy editor, but not after saving a node. Any ideas why?

Log in or register to post comments

Comment #10

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 17:23

I turned off pathologic module and now relative paths work also. But what I should do with existing links? It is really a lot of work to manually reinsert all images...

Log in or register to post comments

Comment #11

pp CreditAttribution: pp commented 21 February 2013 at 17:29

micz_ thanks for your review!

#10
"I turned off pathologic module and now relative paths work also."
This is a different issue

"But what I should do with existing links? It is really a lot of work to manually reinsert all images..."

This is a good question, but not this issue. :)

If you agree whit this, please set this issue to rtbc

Log in or register to post comments

Comment #12

pp CreditAttribution: pp commented 21 February 2013 at 17:30

"But what I should do with existing links? It is really a lot of work to manually reinsert all images..."

Make a little filter module which replace old links to new with image_style_url.

Log in or register to post comments

Comment #13

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 17:33

Status:

Needs review

» Reviewed & tested by the community

pp, thanks for help! :) should I create issue on pathologic issue queue?

Log in or register to post comments

Comment #14

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 21 February 2013 at 17:35

#12 I have no idea how to do that...

Log in or register to post comments

Comment #15

pp CreditAttribution: pp commented 21 February 2013 at 17:38

Status:

Reviewed & tested by the community

» Needs review

micz_ make an issue in Drupal Core issue queue.

Log in or register to post comments

Comment #16

pp CreditAttribution: pp commented 21 February 2013 at 17:39

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

Comment #17

Olafski

Hamburg

CreditAttribution: Olafski commented 21 February 2013 at 20:08

@micz_ #7, I guess on my site it's "Responsive images and styles", so I created an issue there: #1923936: Responsive images and styles module doesn't work with Drupal 7.20

Log in or register to post comments

Comment #18

David_Rothstein CreditAttribution: David_Rothstein commented 21 February 2013 at 22:53

Title:

doesn't work with drupal 7.20

» Insert module doesn't work with Drupal 7.20

Changing the title a bit, since I'm going to link to this from the Drupal 7.20 release announcement and release notes (in the "known issues" section)...

The patch seemed to work for me also. If it's necessary to make it work with older versions of Drupal core too, the new code could be wrapped in a function_exists('image_style_path_token') check. (Right now, I think it will lead to a fatal error with older versions.)

Log in or register to post comments

Comment #19

przemekz CreditAttribution: przemekz commented 22 February 2013 at 00:17

@ micz_

http://drupal.org/project/ispreg is a temporary solution for broken links. Remember to install VBO.

@ pp #8
Patch doesn't work with File (Field) Paths.

Log in or register to post comments

Comment #20

pp CreditAttribution: pp commented 22 February 2013 at 05:00

przemekz(or anybody): could you help me to clarify "doesn't work" ?

1. Patch made for insert module not File (Field) Paths. Did you try to apply this patch for File (Field) Paths git repository?

2. Could you write a short usecase to me? I never use File (Field) Paths and Insert module together. If I can't reproduce your problem, then I can't resolve it.

Log in or register to post comments

Comment #21

pp CreditAttribution: pp commented 22 February 2013 at 05:11

Status:

Reviewed & tested by the community

» Needs review

File	Size
1923336-13.patch	957 bytes

David_Rothstein: #18 is a good point.

Please review.

Log in or register to post comments

Comment #22

pp CreditAttribution: pp commented 22 February 2013 at 06:46

File	Size
setup_filter.png	116.61 KB

micz_ #12
Here is the module: https://drupal.org/project/1924318/git-instructions

Please try it.

Usage:

Enable module
go to the Text formats admin page (admin/config/content/formats) and enable filter to all formats (see picture.)

Log in or register to post comments

Comment #23

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 22 February 2013 at 11:46

pp #22
It does the job! Great :) How it works? I Can see itoken attached to the end of img links only in view mode in my content body field but not in edit view-source wyswigy mode.

I have uninstall this module, flush cache and image cache, install corrector again and I have itoken added twice. I have a local copy of db, but somebody else could not have it.

Sorry for my english.

Log in or register to post comments

Comment #24

pp CreditAttribution: pp commented 22 February 2013 at 12:53

micz_ https://drupal.org/node/1924618 This is a different issue, a different module.

Log in or register to post comments

Comment #25

przemekz CreditAttribution: przemekz commented 22 February 2013 at 14:27

@ #20
I obviously patched Insert module.

I have File (Field) Paths installed and created path for images (field) "images/[current-date:custom:Y]_[current-date:custom:W]/field_images". My public directory is "files" not "sites/default/files".

When I upload and insert some image with style then the image's path is for example /files/styles/my-style/public/myfile.png?itok=0eCQczX- and is OK.
But when I save the node then the uploaded image's path is /files/images/2013_08/field_images/myfile.png. The uploaded image is moved to the custom directory and the path in body field is updated. The new path for the style is /files/styles/my-style/public/images/2013_08/field_images/myfile.png?itok=0eCQczX- and the image doesn't exist.

I suppose that the image_style_path function (image.inc) is never called using as argument /files/images/2013_08/field_images/myfile.png and so the file /files/styles/my-style/public/images/2013_08/field_images/myfile.png?itok=0eCQczX- will never be created.

Sorry for first detailed description it was 2:17 am.

Log in or register to post comments

Comment #26

bluehead CreditAttribution: bluehead commented 22 February 2013 at 16:20

Patch #21 works
Thanks

Log in or register to post comments

Comment #27

Qandeel CreditAttribution: Qandeel commented 23 February 2013 at 06:18

Patch # 21 works, I have tested on all of my client's site, thanks

Log in or register to post comments

Comment #28

pp CreditAttribution: pp commented 23 February 2013 at 07:44

przemekz #25

Thank's for clarifying. I can reproduce the bug.

This is an File (Field) Paths module bug, because it modifies the image path, but not regenerates image token:
http://drupal.org/node/1925298

bluehead, Qandeel(or anybody who test this patch :) )
Thank's for your review.
Can you change issue status to rtbc?

Log in or register to post comments

Comment #29

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 23 February 2013 at 10:12

Patch #21 works!

Log in or register to post comments

Comment #30

Qandeel CreditAttribution: Qandeel commented 23 February 2013 at 15:10

I think this patch should be considered major and I am hoping a quick fix release from maintainer of this module. Can we have some words from the maintainer.???