Field name/label disappears when I create a new entity inline

Same issue here. Only applies when the IEF field is required.

After having a closer in the InlineEntityFormComplex class:

This is where the add form gets rendered (shown by default if the field is required) (1):

else {
      // There's a form open, show it.
      if ($form_state->get(['inline_entity_form', $this->getIefId(), 'form']) == 'add') {
        $element['form'] = [
          '#type' => 'fieldset',
          '#attributes' => ['class' => ['ief-form', 'ief-form-bottom']],
          'inline_entity_form' => $this->getInlineEntityForm(
            'add',
            $this->determineBundle($form_state),
            $parent_langcode,
            NULL,
            array_merge($parents, ['inline_entity_form'])
          )
        ];

The wrapper fieldset loses its label when this field has no existing entities yet (2):

// No entities have been added. Remove the outer fieldset to reduce
// visual noise caused by having two titles.
if (empty($entities)) {
  $element['#type'] = 'container';
}

What if we change the element type from fieldset to container for (1) and remove the no-entities-added case (2)? This would remove the visible fieldset around the inline entity add form, but would maintain the IEF its label all the time.

#4 works fine for me. Thanks!

Yes... when I changed my IEF to Required, the field label disappeared.

Patch in #4 is working for me, too.

Oddly, duplicate titles are shown when the "Simple" version of the form field is displayed. I'm curious why this code is in the the InlineEntityFormComplex.php instead of InlineEntityFormSimple.php.

Hello,
The #4 patch applied correctly and working as expected.
+1 for RTBC.
Tested on dev branch.
Simple form works ok for me.

I wonder if removing the fieldset has negative accessibility implications. Still, losing the label is even worse ...

The Patch 4# works perfectly for me!

The patch #4 doesn't work for me.

The patch #4 doesn't work for me because i have multiple values in the field IEF.

When i tried add something from the list, the name disapear from the legend of the fieldset.

Setting to needs work based on #14.

I found the solution that i looking for, but i don't know how to up the changes.

@HumbertoJZG it would really help if you could explain precise steps to reproduce the problem, and say what solution you found.

I have multiple values in the inline_entity_form_complex field, when i pick one, i see the form. But the field/name for the legend desapear.

Then check if there was an open form, and pass the title of the type of referenced content I want to show.

After to applying my changes, i can see the field/name for the legend. work for me.

I meant to set this to NW in my last comment...

Thanks a lot for debugging this!

To me it looks like #3/#4 spots the code to look into, but adds the wrong solution. This must be fixed without changing existing markup (except for the buggy ;-). Let's find the right condition for the "Remove the outer fieldset" part, maybe involving $open_form.

In my case, the code below changes the wrapper element from a "details" to a "container". This causes the parent field (invoking IEF) to lose it's title and description (see keep/removed screenshots). In my instance I want to keep all this stuff, but maybe things like commerce want it removed.

Line 577:

      // No entities have been added. Remove the outer fieldset to reduce
      // visual noise caused by having two titles.
      if (empty($entities)) {
        $element['#type'] = 'container';
      }

#4 works for me even for multiple values field. From comments #14, #16, #18 I have not understood what is wrong and alternative solution wasn't provided.

Issue is in the code:

// No entities have been added. Remove the outer fieldset to reduce
      // visual noise caused by having two titles.
      if (empty($entities)) {
        $element['#type'] = 'container';
      }

From the history I see that this code is from D7 version. There isn't fieldset wrapper in D8 version. $element['#type'] == 'details' now. There is a difference how collapsible elements work in D7 and D8 - https://www.drupal.org/node/1852020. I have not found "visual noise caused by having two titles" after removing this code.

After applying patch #23 additional border is shown in comparing with solution #4 but might be this solution is more consistent based on the implementation of the form in another cases and #20.

This seems like the right approach to me.

Good job with #23, looks good and it works.
However, this should be tested. @sinn, please extend the ComplexWidgetTest to check for the presence of this element and the title.

Test that shows the issue is attached.

Test with solution is attached.

Looks good to me, thanks @sinn!

Tested, works for me

Reviewed and tested, thanks @sinn!

That looks to solve the problem for me too, thanks @sinn

> To me it looks like #3/#4 spots the code to look into, but adds the wrong solution. This must be fixed without changing existing markup (except for the buggy ;-). Let's find the right condition for the "Remove the outer fieldset" part, maybe involving $open_form.

I think what @geek-merlin means here is that it feels a bit iffy to just remove this chunk of code without understanding what it was trying to do.

> // No entities have been added. Remove the outer fieldset to reduce
> // visual noise caused by having two titles.

When would two titles be shown?

The patch works for me on the complex widget, but I'm wary of committing it in case it breaks something we've not considered.

#23 attempts to answer these questions and explain the history. Can you say in what way it is insufficient.?

> Can you say in what way it is insufficient?

In the 'co-maintainer was multi-tasking while using this module on a work project and didn't read all of the comments' way ;)

I'll commit this when I have a moment.

Thank you for the explanation.

Committed.

Thanks to everyone who's worked on this issue.