Problem/Motivation

The field label for the existing entity autocomplete gets all words capitalised. In most cases this is not needed.

Proposed resolution

Swap ucwords with ucfirst.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#10 interdiff.txt812 bytesclaudiu.cristea
#10 2764007-10.patch960 bytesclaudiu.cristea
#3 capitalize_only_first-2764007-3.patch783 bytessardara
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sardara created an issue. See original summary.

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for Government of Flanders commented
Issue summary: View changes
sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: sardara » Unassigned
Status: Active » Needs review
FileSize
capitalize_only_first-2764007-3.patch783 bytes
yoroy’s picture

yoroy CreditAttribution: yoroy commented
Issue tags: +Usability

This sounds sensible but a before/after screenshot would make this easier to understand :-)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Issue tags: +Needs screenshots

Thank you @yoroy for looking into this issue!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Needs work
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented

The whole labels singular/plural stuff should be resolved through #2765065: [PP-1] Allow plurals on bundle labels, when that one lands.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Related issues: +#2765065: [PP-1] Allow plurals on bundle labels
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

I agree, let's maybe add a todo referencing that?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
2764007-10.patch960 bytes
interdiff.txt812 bytes

Sure. With the @todo I think this is good to go as a temporary solution until #2765065: [PP-1] Allow plurals on bundle labels.

@dawehner, do you think you have some time to review #2765065: [PP-1] Allow plurals on bundle labels? I can explain you in detail why that looks like stuck.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Fixed

Thank you for updating the issue!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Fixed » Reviewed & tested by the community

@dawehner, you fixed the issue but you haven't committed the patch

  • dawehner committed 44c5cfc on 8.x-1.x authored by sardara 
    Issue #2764007 by claudiu.cristea, sardara: Capitalize only first letter...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

Oh I forgot to push it. Sorry.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.