Problem/Motivation
8.x-1.x branched of 7,x-1.x a while ago. We have to make sure that all bugs/changes form 7.x-1.x are in 8.x-1.x. The last common ancestor is 67729a2. Here is a list of all commits since 8.x-1.x branched off.
To do list
- #2343689: D7: Multiple forms submit/cancel closes all child forms
- #2206197: Nested Inline Entity form, issues on node creation with duplication of nested items
WIP
Done
- #1590146: Clone referenced entities
- #2612720: Forward port submission improvements (#ief_element_submit) to D8
- #2187103: inline_entity_form_form_alter() incorrectly combines form level and button level submit handlers
- #2056139: Add option in setting to "Prevent adding a new entity".
- #2174995: commerce_product_line_item_populate() not called for product line item types
- #2170965: WSOD when Views is not enabled
- #2165113: Undefined index: #submit at inline_entity_form_form_alter()
- #2186553: Insignificant typo in inline_entity_form.api.php causes error
- #2074127: Unknown fields added via inline_entity_form_table_fields
- #2324901: Add callback field type for theme_inline_entity_form_entity_table
- #1876652: Weight delta only supports ordering of 50 items
- #2218887: missing documentation in hook_inline_entity_form_table_fields_alter()
- #2185061: Make sanitizing entity property output in the IEF table optional
Proposed resolution
Remaining tasks
User interface changes
API changes
Original issue summary
* 887eec8 - (drupal/7.x-1.x) Issue #2056139 by joelpittet, svenssson: Add option in setting to "Prevent adding a new entity" (7 weeks ago) * 566f641 - Issue #1876652 by fearlsgroove, criz: Weight delta only supports ordering of 50 items (7 weeks ago) * 47ffa63 - Issue #2218887 by joachim: Fixed missing documentation in hook_inline_entity_form_table_fields_alter(). (6 months ago) * 93efa62 - Issue #2343689 by fearlsgroove: Fixed Multiple forms submit/cancel closes all child forms. (6 months ago) * 7895c2a - Issue #2206197 by adolfo.mansilla | jnicola: Fixed Nested Inline Entity form, issues on node creation with duplication of nested items. (6 months ago) * 7b5e448 - Issue #2324901 by yannickoo, axe312, marcusx: Added callback field type for theme_inline_entity_form_entity_table. (6 months ago) * 8229859 - Issue #2223005 by rszrama: Inline_entity_form_cleanup_entity_form_state() doesn't check for an instance's presence in an entity form. (1 year, 1 month ago) * 3e93c85 - Issue #2185061: Make sanitizing entity property output in the IEF table optional (1 year, 2 months ago) * d4c7af0 - Issue #2186553 by sender: Fix typo in inline_entity_form.api.php (1 year, 2 months ago) * 37959cc - (tag: 7.x-1.5) Issue #2074127: Prevent error when the IEF table is trying to show a field not found on the entity. (1 year, 3 months ago) * 163d478 - Clean up inline_entity_form_form_alter(), fix issues with some forms being submitted twice. (1 year, 3 months ago) * 524cdbb - Issue #2174995: commerce_product_line_item_populate() not called for product line item types. (1 year, 3 months ago) * 1a65c1f - Improve inline_entity_form_field_widget_properties_alter(), avoid calling module_exists() for non-IEF widgets. (1 year, 3 months ago) * d189bcc - Issue #2173539 by fearlsgroove: Views Bulk Operation (VBO) modify entity values broken again. (1 year, 3 months ago) * d4192bc - Issue #2170965 by jgullstr, bojanz: Prevent WSOD when Views is not enabled. (1 year, 3 months ago) * a2158c2 - Issue #2165113 by andyg5000: Undefined index: #submit at inline_entity_form_form_alter(). (1 year, 3 months ago)
Comment | File | Size | Author |
---|---|---|---|
#14 | 13-IEF-D8-callback-field-type.patch | 4.23 KB | jan.stoeckler |
#14 | interdiff-12-13.txt | 1.94 KB | jan.stoeckler |
#12 | IEF-D8-callback-field-type.patch | 2.28 KB | jan.stoeckler |
Comments
Comment #1
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #2
slashrsm CreditAttribution: slashrsm at Examiner.com commented- #2165113: Undefined index: #submit at inline_entity_form_form_alter() seems to be non-relevant
- #2498487: Remove hook_field_widget_settings_form and other hooks deleted from Drupal 8 basically resolves #2170965: WSOD when Views is not enabled
Comment #3
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #4
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #5
slashrsm CreditAttribution: slashrsm at Examiner.com commentedPatch for #2074127: Unknown fields added via inline_entity_form_table_fields uploaded.
Comment #6
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedCherry-picked d4c7af0 (#2186553: Insignificant typo in inline_entity_form.api.php causes error) to 8.x-1.x
Comment #7
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedPatch for #1876652: Weight delta only supports ordering of 50 items uploaded.
Comment #8
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #9
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #10
webflo CreditAttribution: webflo at UEBERBIT GmbH commented#2324901: Add callback field type for theme_inline_entity_form_entity_table has a patch on https://github.com/webflo/inline_entity_form/pull/2
Comment #11
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #12
jan.stoecklerPatch to address #2324901: Add callback field type for theme_inline_entity_form_entity_table based on https://github.com/webflo/inline_entity_form/pull/2.
Comment #13
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #14
jan.stoecklerFollowup to correct renamed keys.
Comment #16
slashrsm CreditAttribution: slashrsm at Examiner.com commentedCommitted #14. Thank you both!
Comment #18
slashrsm CreditAttribution: slashrsm at Examiner.com commentedAlso committed patch in #1876652: Weight delta only supports ordering of 50 items.
Comment #19
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedCreated #2531574: Use field formatter for table fields to fix #2218887: missing documentation in hook_inline_entity_form_table_fields_alter() and #2185061: Make sanitizing entity property output in the IEF table optional
Comment #20
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #21
bojanz CreditAttribution: bojanz commentedAdding #1590146: Clone referenced entities, one of IEF's oldest feature requests fixed.
Should be easier in D8 since all entities have a createDuplicate() method we can use. The actual functionality should also be called "Duplicate" to match D8 terminology. I went with "Clone" in D7 because that's what the Entity API module used.
Comment #22
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #23
bojanz CreditAttribution: bojanz commentedWe should also check if anything needs to be done for #2187103: inline_entity_form_form_alter() incorrectly combines form level and button level submit handlers.
Comment #24
bojanz CreditAttribution: bojanz commentedComment #25
bojanz CreditAttribution: bojanz commentedPorted #2056139: Add option in setting to "Prevent adding a new entity"..
Comment #26
bojanz CreditAttribution: bojanz commentedRemoving #2223005: inline_entity_form_cleanup_entity_form_state() doesn't check for an instance's presence in an entity form because D8 has the same check already.
Confirmed that #2187103: inline_entity_form_form_alter() incorrectly combines form level and button level submit handlers is valid and needs porting.
Comment #27
slashrsm CreditAttribution: slashrsm at Examiner.com commentedComment #28
bojanz CreditAttribution: bojanz commentedConfirmed #2187103: inline_entity_form_form_alter() incorrectly combines form level and button level submit handlers is not relevant anymore.
Comment #29
bojanz CreditAttribution: bojanz commentedComment #30
m4oliveiI've got a patch complete with tests for #2343689: D7: Multiple forms submit/cancel closes all child forms, anyone care to review?
Comment #31
Gábor HojtsyComment #32
ilya.no CreditAttribution: ilya.no as a volunteer and at Skilld for Skilld commentedHello all!
I've uploaded patch for Clone referenced entities issue.
Comment #33
bojanz CreditAttribution: bojanz commented#1590146: Clone referenced entities is done.