IEF doesn't invoke node_validate() [#2022805]

Thought this might be the same bug as #1941812: Inline entity form doesn't enter in validation function with Conditional Field but I just checked and conditional_fields doesn't use hook_node_validate() to do its thing, so this is a separate bug.

NodeInlineEntityFormController overrides entityFormSubmit() to invoke node_submit() and friends, but it doesn't do the same for node_validate(). This breaks modules like unique_field and is generally an extremely dangerous thing to do. Sites might bake all sorts of validation into their nodes, and if that can be totally bypassed via IEF, badness ensues. ;)

Comment	File	Size	Author
#9	inline_entity_form.2022805.9.patch	2.38 KB	phayes
#9
#7	inline_entity_form.2022805.7.patch	2.37 KB	phayes
#7
#6	inline_entity_form.2022805.6.patch	2.37 KB	phayes
#6
#1	2022805-1.ief-node-validate.patch	1.09 KB	dww
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dww

we/he/they

CreditAttribution: dww commented 19 June 2013 at 00:01

Status:

Active

» Needs work

File	Size
2022805-1.ief-node-validate.patch	1.09 KB

Ugh, this is a can of worms. :( I tried the attached patch, and now at least hook_node_validate() is geting invoked. However, when you call form_set_error() from an implementation of that hook, nothing really happens and the form submits, anyway...

But, this is at least a start.

Comment #2

bojanz CreditAttribution: bojanz commented 23 June 2013 at 11:09

Would it be enough to do:

$form_errors = &drupal_static('form_set_error', array());
if (!empty($form_errors)) {
  $form_state['rebuild'] = TRUE;
}

After the call to node_validate()?

Comment #3

vasike

Ramnicu Valcea

CreditAttribution: vasike commented 23 July 2013 at 16:30

Status:

Needs work

» Active

it couldn't see a way for a solution. maybe the reverse way could be a solution.
in the given case - IEF integration as feature request for Unique field.
Maybe Field validation module could an alternative solution - i didn't test to see if it works?

bojanz : should this kind ("impossible look like") of issues should be on project page or documentation as known issues?

Comment #4

archnode CreditAttribution: archnode commented 6 August 2013 at 12:44

I can confirm that the Field validation module indeed works with IEF if you specify the "Set errors using field API " option.

Comment #5

bojanz CreditAttribution: bojanz commented 27 December 2013 at 18:19

Issue summary:	View changes
Status:	Active	» Needs work

This is doable, the code needs to catch the newly set form errors and set them on the correct form elements (the ones with the correct parents).

Comment #6

phayes CreditAttribution: phayes commented 29 January 2015 at 19:13

Status:

Needs work

» Needs review

File	Size
inline_entity_form.2022805.6.patch	2.37 KB

Attached is a patch that fixes this issue.

The situation is complicated by the fact that node_validate thinks it's validating the entire form, where in reality it's only validating a single element, so we need to do a little bit of manual intervention on the static form error and validation-limits, but it seems to work well.

Please review.