Closed (fixed)
Project:
Inline Ajax Search
Version:
6.x-3.9
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
12 Sep 2010 at 20:46 UTC
Updated:
30 Sep 2010 at 16:20 UTC
This is a damn fine module, bringing Drupal search to life, thank you for making it!
1. It seems the target option isn't working 100%. Even though I have set "Target of the links" to "Self", the link opens up in a new window.
2. Also, the search results were pushing the rest of the page content down. I copied this CSS from your example link, perhaps it should be included in the module?
/* Inline Ajax Search */
#block-inline_ajax_search-0 {
position:absolute;
/* right:8px; */
z-index:20;
}
#block-inline_ajax_search-0 #inline_ajax_search_results {
-moz-box-shadow:0 0 10px #666666;
background-color:#EBEBEB;
clear:both;
/* float:right; */
opacity:0.9;
padding:8px;
width:400px;
}
3. Perhaps include a reminder in the README.TXT that the Inline AJAX search block has to be enabled?
Comments
Comment #1
fabianderijkI've added the default css and changed the readme.txt as you said, the problem with the target isn't in my install. With me it all works fine. Coul;d you let me know if the value is of the inline_ajax_search_target variable?
The new additions are available in the new nightly build.
Comment #2
ressaThank you for the quick reply.
I have tested a bit now, and I think it's a php version issue, though I am not sure. On a machine with php version 5.3.1 a new window opens, on a machine with php version 5.2 it respects the target setting.
Just to make sure, how can I check the value of the inline_ajax_search_target variable, with devel or DrupalForFirebug?
On another note, is there a way to wait with submitting the search string until, for example, 500 milliseconds after the last key press? As it is now, the search is sent away right after the third key press. For example, if you are searching for "trek" and you are on a slow host, the string "tre" is submitted and the result will show the result for "tre" even thought the search form says "trek", which is a bit confusing 8o)
Comment #3
fabianderijkIt could be a PHP version related problem. I know that Drupal doesn't like the 5.3 version of PHP.
You can check the variables when you have the devel module installed. The url is: http://www.example.com/devel/variable
The delay is a problem i'm aware of, in the dev version there is a check to kill the running ajax request before submitting the new one. But the delay is also something that has to be added.
Comment #4
ressaThanks for the tip -- on the devel/variable page:
The links still say target="_blank" though, strange...
Great to hear you are looking at the delay issue, but I can't find the check to kill the running ajax request before submitting the new one. Shouldn't it be at admin/settings/search/inline ? Or is it set in the code?
Comment #5
fabianderijkThe check is done on the code, not as a setting. It's something you would always want the module to do.
Comment #6
fabianderijkCan this module be set to status fixed? I think so, the latest comment were not part of the initial problem were they?
Comment #7
ressaSure, the latest comment were about something else. Perhaps add a bit in the README that servers with php version 5.3 might have the target problem? If that is actually the cause...
It would be great though, if it was possible to have an adjustable setting where the module doesn't submit the query until, for example, 750 milliseconds after the last key press. I will just wait with installing this fantastic module on my site until I move it to a dedicated server, where bandwidth won't be an issue.
Or can you see an easy way of implementing something like a Typewatch function?
http://plugins.jquery.com/project/TypeWatch
I tried to implement it in inline_ajax_search.js, but really suck at javascript, so I couldn't make it work...
Comment #8
fabianderijkTypewatch is a nice jquery plugin indeed, I will see if I can implement it, or mimic it's behaviour.
The addition to the README file about the PHP version isn't needed. Drupal is known to work buggy on PHP 5.3, so it's not my module, it the variable_get function probably that's causing the issue.
Comment #9
ressaGreat, I can't wait to see the result. I know your time to work on the module is limited -- I am very grateful, whenever you have time to look into it.