Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
I tried to credit every contributor to the multilingual initiative on #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed . There are 1600 or so.
Here are issues caused/occurred:
- Things properly broke when the issue got to about 1061 comments because d.o unpublished the issue and won't re-publish until a few comments had been deleted.
- Everybody who is credited on the issue is also subscribed to the issue - this is wrong we shouldn't be automatically subscribing people to issues when they are credited.
- Deleting the comment that credits the user also removes the credit - I guess this is just a feature of the issue credit system since you need a comment for credit.
(apparently) Users are sent an email from me using my email address informing that they are credited. I think this should use the system email and not disclose mine.
Whilst my intentions are good - I realise I might have caused some people some work - I'm sorry. Also not sure this is in the right queue - sorry.
Proposed resolution
Things to do:
Unsubscribe everyone who is subscribed to #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed because of my crediting.Done- Somehow credit all the people listed in the issue summary on #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed .
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#18 | uids_to_credit.txt | 4.93 KB | alexpott |
Comments
Comment #2
alexpottComment #3
Wim Leers:O :O :O :O :O
Comment #4
xjmSo for now I would suggest:
Comment #5
alexpottI think that we definitely should have an issue to issue the fact that crediting someone subscribes them to the issue - another user shouldn't be able to force subscribe someone to all future comments on the issue. It's great people get an email saying you've been credited but that's all that should happen.
Comment #6
drummCredit is stored as entity references to comments by credited people. Any organizations referenced are on those comments, so it let’s people update that by editing their comment. When you credit someone, the underlying implementation is actually to post a comment as the credited person.
To credit everyone, I’d do it like you did, but in separate issue batches of 900 or less. After improvements from this issue. And maybe programmatically rather than via the UI.
Comment #7
drummI think this rises beyond the permissions of webmasters.
Comment #8
drummDone.
Comment #9
drummThe header on my credit email from this is:
From: "alexpott (Drupal.org)" <noreply@drupal.org>
I can’t spot your email anywhere in the message.
Comment #10
drummWe haven’t verified this in the logs, but it sounds like Suhosin. Suhosin strips POST data which is out of its limits, and the published checkbox is at the end of POST data.
Comment #11
alexpott@drumm yep you are right re #9 - I was just reporting what I was told - hence the "apparently" - because I didn't really believe it :)
suhosin is an interesting thing see #2665152: Simplify module form structure and fix bugs when Suhosin is used
Comment #12
drummMy thinking there was the usual case for crediting someone who hasn’t commented is that they helped out in a discussion, and I would think their ongoing input would be relevant and useful. And since these are comments posted as the person being credited, that all happened by default, so the implementation was easy.
I think that’s a debate for a separate issue. I don’t have any information on whether people being credited expect to follow the issue or not; or if they like or don’t like being auto-followed.
Comment #13
drummI recommend posting a second issue to credit the remaining ~600 people in the same way, and I’ll unfollow them shortly after.
#12 and any other followups shouldn’t need to block that.
Comment #14
jhodgdonRE #12 and the discussion about auto-following... This one issue was kind of a special case, due to the huge number of people being credited. I was one of the people who started getting lots of emails about the issue, due to the auto-following, and I can tell you that I didn't appreciate it very much. Also, when I went to the issue page to try to un-follow the issue, some JavaScript on the page (possibly dreditor?) made it load very very slowly, so unfollowing it was difficult.
That said, in the more normal case of "I know this person worked on this issue because it was spun off of something else but they haven't commented here yet", I don't think that having the person being credited automatically Follow the issue is a completely terrible thing... But then again, for those of us who have hundreds (if not more) issues that they follow, getting another Follow added by someone else is not a great thing either.
So I think I'm falling in with the "Credit != follow" crowd. If I get a "you've been credited" message, I can click on the link and follow the issue if I want to keep getting notified about it.
I guess you wanted this discussion on a separate issue, but this one only has 5 followers so far, and there isn't another one yet... so.
Comment #15
jhodgdonAlso +1 to the suggestion in #6. Delete all the current credit comments on the main issue, then make child issues to credit people, each with fewer comments (600 was suggested, so you'd need 3 child issues). That will (a) make sure each person is "credited with fixing a Drupal Core issue" (for profile/marketplace ranking counts) and (b) not overwhelm the system. And maybe those credit comments can be added programmatically without causing a "follow" for this one case.
Comment #16
drumm#2853669: Crediting someone in an issue should not cause them to follow the issue is the followup for the following behavior.
Comment #17
drummI recommend leaving #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed as-is.
I’ll make a script which mass-adds credit to a fresh separate issue. The plan is to have it send the “[@project] You’ve been credited in @title!” email to everyone, but not follow the issue. There will be a small number of people that get double-notified, the ones who got caught in the deleting-until-the-issue-worked. We don’t need to make that number higher.
Comment #18
alexpottHere's the list of UIDs left to credit. Thanks @drumm
Comment #19
drummIn case this comes up again, the script I'm using is
executed with
--user=157725
Comment #20
drummThe second batch of credit is at #2853680: Remove multilingual initiative from MAINTAINERS.txt as completed. I think this is all handled.
Comment #21
drummComment #22
xjmSo it looks like anyone who actually commented as a real human on #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed was not credited nor included in the commit message, including me, penyaskito, and vijaycs85 at least. We are unchecked on #2850540: Remove multilingual initiative from MAINTAINERS.txt as completed and not added on #2853680: Remove multilingual initiative from MAINTAINERS.txt as completed, and not listed in the commit message.
Comment #23
xjmSo regarding #22, @alexpott has re-checked those who were missed.
To fix the commit message, we agreed this might be the best course:
git revert 8c01266a8c
and
git revert a6ed0958
but do not use the ~KB-long default message; instead:
Revert "Issue #2850540": fixing issue credit
Comment #24
alexpottI carried out the plan in #23. Consider Acquia's OCTO slack channel spammed :)