http://drupal.org/project/advagg would be useful on d.o for a number of reasons; the main on is preventing CSS files from disappearing when a cache flush is done. For us, AdvAgg has allowed us to never worry about CSS/JS aggregation issues, ever.

Warnings to resolve

  • The cache-control's max-age header being sent by your web server is not at least 1 month in the future.
    The web servers configuration should be adjusted only for AdvAgg files. Was looking that the max-age second counter is over 2,628,000 (1 month), actually got max-age=1209600.
  • The wrong Content-Type is being sent by your web server.
    The web servers configuration will need to be adjusted. Was looking for application/javascript, actually got text/javascript. You might need to apply the drupal core patch located here https://drupal.org/node/2193333#comment-8469991.
  • The expires header being sent by your web server is not at least 1 month in the future.
    The web servers configuration should be adjusted only for AdvAgg files. Was looking for a second counter over 2,628,000 (1 month), actually got 1,427,411,609

Deployment

  • pm-enable advagg
  • Deployment with cc all

Comments

DamienMcKenna’s picture

Project: Drupal.org site moderators » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Redesign » User interface

I believe this request should be in the d.o customizations project?

dww’s picture

Project: Drupal.org customizations » Drupal.org infrastructure
Version: 7.x-3.x-dev »
Component: User interface » Drupal.org module

Actually, this is better. The "Drupal.org customizations" queue is specifically for the drupalorg.module (and friends) to manage customizations to d.o via code. Deploying a separate contrib module is something for the infra team to consider.

Thanks,
-Derek

mikeytown2’s picture

Noted that whitehouse.gov uses the 6.x branch. I would wait till a stable release of AdvAgg 7.x comes out if the target version is D7.

DamienMcKenna’s picture

Status: Active » Postponed

@mikeytown2: That's what I was figuring too, lets leave it as Postponed until you're happy it has reached a point stable enough for heavy production use.

dww’s picture

Good idea. I doubt anyone on the infra team will want to mess with this until after the D7 launch of d.o, anyway.

mikeytown2’s picture

Just a heads up that AdvAgg is at RC2 and will most likely have a final version unless a lot of issues come in in the next 2 weeks.

mikeytown2’s picture

Status: Postponed » Active

1.0 is out. Note that AdvAgg contains a validator submodule that will follow these rules when using JSHint
https://drupal.org/node/1955232. Will also validate CSS using CSSLint using the standard rule set as I have not found a non standard one defined #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core.

mikeytown2’s picture

Issue summary: View changes

Any word on this?

Project: Drupal.org infrastructure » Drupal.org customizations
Component: Drupal.org module » Miscellaneous
mikeytown2’s picture

Version: » 7.x-3.x-dev
Category: Feature request » Task

Just saw this change notice for d.o
https://www.drupal.org/node/2446971

Let me know what issues might arise with this. Just using the base module with the defaults is the safest.

drumm’s picture

Assigned: Unassigned » drumm

Thanks, good to know. This got agiled to the top of the backlog before we could find the issue. Deployments (and downtimes) during busy hours have been rough lately.

drumm’s picture

There are a lot of commits since 7.x-2.7. Is 7.x-2.7 working well enough?

mikeytown2’s picture

Going over the log and some of the improvements in the latest dev has to do with the reduction of queries as well as fixing some bugs.

Some of the bugs fixed in the latest dev when compared to 7.x-2.7
#2326695: If one file defines "async=true" on same group all files will be aggregated to same group and set to async
#2412093: IE CSS Selectors limiter doesn't work with less module
#2412213: Wrong media queries on @imports
#2353811: Aggregated CSS/JS references the domain it was generated on
#2422581: Call _drupal_flush_css_js() when changes to css/js are made
#2364681: Error message showing after enabling - Prevent more than 4095 CSS selectors in an aggregated CSS file
#2362643: Drupal alters svg fill paths with base url -> broken svg
#2349101: hook_ajax_render_alter removes any commands for settings to be merged
#2340653: JS aggregates are not deleted

If you are going to use the latest dev; which I recommend due to the reduction in the number of queries as well as some bug fixes with multisites then at this point do not use the aggressive cache #2435153: Settings is undefined. Outside of this issue the dev version should be good to use. I'll be working on it and I hope to get 7.x-2.8 out the door fairly soon as the query reduction is a big improvement in this module.

If you use 7.x-2.7 then turning on the aggressive cache is recommended. I reworked the code in the latest dev; thus that bug report I linked to in the previous paragraph is not present in the last stable version.

drumm’s picture

Thanks, I'll go with the dev version, or 2.8 if available next week. Usually I'd stick to 2.7, but I don't want to deploy a whole rework of this in the near future.

I'll likely be deploying this early or mid next week.

drumm’s picture

Status: Active » Needs review

advagg e42183f is now enabled on https://staging.devdrupal.org.

drumm’s picture

Title: Use Advanced CSS/JS Aggregation on drupal.org » Use Advanced CSS/JS Aggregation on Drupal.org
Project: Drupal.org customizations » Drupal.org infrastructure
Version: 7.x-3.x-dev »
Component: Miscellaneous » Servers
Issue summary: View changes
Status: Needs review » Needs work

We have a few warnings to resolve, adding them to the issue summary.

Since it is getting late for a large deployment this week, we'll postpone until next week while we get the server configurations cleaned up.

drumm’s picture

Status: Needs work » Fixed
Issue tags: +needs drupal.org deployment

We've got most of the warnings resolved on staging, this is ready to try in production about an hour from now.

drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed. No problems reported so far.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.