The relative path is used instead of the absolute URL

For example: http://drupal.org/node/992020#comment-4556200, #1178410: Change simpletest core patch to use git apply (-p1)

Comments

boombatower’s picture

boombatower CreditAttribution: boombatower commented

The culprit would seem to be the following from pift.cron.inc.

'file_url' => file_create_url($file['filepath']),

I'm not sure why that would return the path instead of URL.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Title: Relative patch file path used instead of absolute » Relative patch file path used instead of absolute in patch testing
Project: Project issue file test » Drupal.org infrastructure
Version: 6.x-2.x-dev »
Component: Code » Webserver
Priority: Normal » Critical

All testbot tests are currently failing due to relative paths being delivered by file_create_url().

I assume that 6.22 was deployed today, and that that is the culprit?

Example failures:
#1178410: Change simpletest core patch to use git apply (-p1)
#992020: Taxonomy autocomplete does not respect cursor position.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

I can confrm that 6.22 was deployed today.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Title: Relative patch file path used instead of absolute in patch testing » All tests failing: Relative patch file path used instead of absolute in patch testing

As far as I can tell, all tests are broken due to this. Haven't investigated.

Is file_create_url() completely broken in 6.22? I'll won't be around much until this evening; not sure about then.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

The culprit is the CDN patch from Pressflow. I hot reverted the change (BZR revision r411) we merged while deploying 6.22. Not sure what the proper fix is, but changing file URLs from absolute to relative looks like a non-API compatible change :/

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
Status: Active » Needs review

Looks like (some) tests are passing once again.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

What was the final outcome with this? Is there action still required?

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Needs review » Fixed

I guess it's fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Component: Webserver » Servers