Problem/Motivation

Cannot save the settings form.

Steps to reproduce

Use imagemagick7 along with version 4 of this module.

Proposed resolution

Change validateConfigurationForm() so it validates using the magick command in case imagemagick7 is in place.

CommentFileSizeAuthor
#11 1d2b5d1b464d3dd01fcad08c4afdbb9c03b448ae.patch16.17 KBweb-beest
#10 1d2b5d1b464d3dd01fcad08c4afdbb9c03b448ae.patch16.17 KBweb-beest
#2 Selection_013.jpg115.21 KBaxroth

Issue fork imagemagick-3451489

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

axroth created an issue. See original summary.

axroth’s picture

axroth commented
Issue summary: View changes
StatusFileSize
new Selection_013.jpg115.21 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented

We will probably need to add configuration + UI to allow site admins to specify which IM version is in use, 6 or 7, then build the command line conditionally. Or have 3 suites to select from, Imagemagick 6, Imagemagick 7 and GraphicsMagick. Besides the change in the name of the executable binary, there are other chnages in the cmdline arguments that potentially are impacted, see https://imagemagick.org/script/porting.php#cli

mondrake opened merge request !41

mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: » #3451489: Imagemagick 7 Compatibility
mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: #3451489: Imagemagick 7 Compatibility » #3410064: Plan for a 4.0.0 release
mondrake’s picture

mondrake
Location 🇮🇹
commented
Component: User interface » Code
Category: Support request » Feature request
Status: Active » Needs review

  • mondrake committed 1d2b5d1b on 4.0.x 
    Issue #3451489: Imagemagick 7 Compatibility
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed
web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
StatusFileSize
new 1d2b5d1b464d3dd01fcad08c4afdbb9c03b448ae.patch16.17 KB

I've rerolled the patch for 8.x-3.x for those who want it :-)

web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
StatusFileSize
new 1d2b5d1b464d3dd01fcad08c4afdbb9c03b448ae.patch16.17 KB

Crikey.. identation problem in schema.yml
Ignore #10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.