Needs Simpletests. 6.x-1.x tests still available in 7.x-1.x repo.

CommentFileSizeAuthor
#7 image_field_tokens_reimplement_simpletest-1845282-7.patch7.44 KBysamoylenko
#5 image_field_tokens_reimplement_simpletest-1845282-3.patch6.88 KBysamoylenko
#3 multiple_registration_user_role_unassigned_3046483-3.patch1.01 KBysamoylenko
#2 image_field_tokens_reimplement_simpletest-1845282-2.patch6.86 KBysamoylenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Assigned: 13rac1 » Unassigned
Issue summary: View changes

Unassigned @13rac1

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
Status: Active » Needs review
FileSize
image_field_tokens_reimplement_simpletest-1845282-2.patch6.86 KB

Hello,

I've implemented new tests for the module.

Please review the patch attached.

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
FileSize
multiple_registration_user_role_unassigned_3046483-3.patch1.01 KB

Incorrect patch attached.

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
FileSize
image_field_tokens_reimplement_simpletest-1845282-3.patch6.88 KB

Coding standards have been fixed. Patch needs to be re-tested.

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
FileSize
image_field_tokens_reimplement_simpletest-1845282-4.patch6.9 KB

New patch version attached.

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
FileSize
image_field_tokens_reimplement_simpletest-1845282-7.patch7.44 KB

Added token composer dependency.

  • ysamoylenko committed a95b2b4 on 7.x-1.x 
    Issue #1845282 by ysamoylenko, Chris Matthews, 13rac1: (Re)-Implement...
ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
Status: Needs review » Fixed

The patch was committed. The first release of the module will be added in a short time.

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
Status: Fixed » Needs review
IreneV’s picture

IreneV CreditAttribution: IreneV at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Tested - tests run passes

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented
Status: Reviewed & tested by the community » Fixed

Thank you for reviewing tests. Currently, I've added them to the latest module release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

5n00py’s picture

5n00py CreditAttribution: 5n00py commented

Why composer.json is added ? It's releted to tests ?

It's incompatible with composer_manager. There is no package "drupal/token": "^1.7" on packagist.org

ysamoylenko’s picture

ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commented

Hello @5n00py,

composer.json was added to the module for the following reasons:
1. Necessary of download module dependencies during module fetching via composer. ("drupal/token": "^1.7" )
2. This dependency should be downloaded via composer to pass tests and module functionality work.

Correct dependencies downloading will be guaranteed if you will use command-line composer version and correct composer repository used in your Drupal project composer.json (https://packages.drupal.org/7)

More info about composer packages: Using packages.drupal.org