Problem/Motivation

Trying to remove the duplicates caused by entity token vs token. #1272560: Entity tokens duplicates field tokens created by token module

I opted for the entity token hyphenated because this is a commerce site and it was less work to remove the underscore _ field names.

Proposed resolution

Provide support for both for now.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 imagecache_token-n2538658-11.patch2.79 KBDamienMcKenna
#11 imagecache_token-n2538658-11.interdiff.txt2.25 KBDamienMcKenna
#9 entity_token_support-2538658-9.patch2.65 KBgturnbull
#4 entity_token_support-2538658-4.patch2.98 KBjoelpittet
#1 entity_token_support-2538658-1.patch2.78 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
entity_token_support-2538658-1.patch2.78 KB

This is not ideal, but posting the patch to stop the bleeding for now...

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

I think this needs a setting to control how it works.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Temporary measure, crossing fingers the argument will be fixed upstream;)

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
entity_token_support-2538658-4.patch2.98 KB

re-roll

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: entity_token_support-2538658-4.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Yeah my patch needs a serious re-roll because of the recent changes, so I've avoided updating imagecache_token on a site due to this...

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Issue tags: +Needs reroll
gturnbull’s picture

gturnbull CreditAttribution: gturnbull as a volunteer and commented
FileSize
entity_token_support-2538658-9.patch2.65 KB

Hi Guys,
I have re-rolled the patch to work with the latest version of the imagecache_token module.

Thanks,
Gordon

gturnbull’s picture

gturnbull CreditAttribution: gturnbull as a volunteer and commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: -Needs reroll +Performance
FileSize
imagecache_token-n2538658-11.interdiff.txt2.25 KB
imagecache_token-n2538658-11.patch2.79 KB

Minor tweaks.