Width and height not set on theme_imagecache properly [#1047416]

I've been working with Insert + Highslide modules and noticed that width and height attributes of imagecache thumbnail are not set until image is generated by imagecache.
I fixed this by customizing theme_imagecache function by replacing these lines:

if ($getsize && ($image = image_get_info(imagecache_create_path($presetname, $path)))) {
    $attributes['width'] = $image['width'];
    $attributes['height'] = $image['height'];
  }

With my new ones:

if ($getsize) {
	  $cachepath = imagecache_create_path($presetname, $path);
	  if (!is_file($cachepath)) {
		  $preset = imagecache_preset_by_name($presetname);
		  $dst = imagecache_create_path($presetname, $path);
		  imagecache_build_derivative($preset['actions'], $path, $dst);
	  }
	  if ($image = image_get_info($cachepath)) {
		$attributes['width'] = $image['width'];
		$attributes['height'] = $image['height'];
	  }
  }

This code generates the image if it's not generated already.

Comment	File	Size	Author
#8	dimensions_missing-1047416-8.patch	968 bytes	fuzzy76
#2	imagecache.module.patch	1.18 KB	jrstmartin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Brodingo CreditAttribution: Brodingo commented 15 June 2011 at 20:58

I tried to override theme_imagecache as phptemplate_imagecache with this code and neither width or height was set when I inserted an image.

Comment #2

jrstmartin CreditAttribution: jrstmartin commented 25 February 2012 at 08:45

File	Size
imagecache.module.patch	1.18 KB

Thank you for this! I was having a problem in Views Slideshow where the first/new slide, which contained an image, was halfway hidden. The height that Views Slideshow's JS was setting on the enclosing <div> was wrong because it couldn't calculate the dimensions of the image contained within it, as the dimensions were not set. This patch sets the dimensions and everything is working!

Comment #3

fizk CreditAttribution: fizk commented 3 June 2012 at 00:59

Category:	bug	» feature
Issue tags:	-insert, -dimensions	+ImageCache 3

Marking as ImageCache 3.x Todo.

Comment #4

j0rd CreditAttribution: j0rd commented 27 July 2012 at 08:39

Same problem and causes a fairly large bug on my website, since I depend on these values being there for some image resizing JS I'm doing. Just noticed this problem after I changed the imagecache's and flushed the images and now my website doesn't work as expected.

// Drupal 7 equiv for those who are curious

function theme_image_style($variables) {
  // Determine the dimensions of the styled image.
  $dimensions = array(
    'width' => $variables['width'],
    'height' => $variables['height'],
  );

  image_style_transform_dimensions($variables['style_name'], $dimensions);

  $variables['width'] = $dimensions['width'];
  $variables['height'] = $dimensions['height'];

  // Determine the url for the styled image.
  $variables['path'] = image_style_url($variables['style_name'], $variables['path']);
  return theme('image', $variables);
}