Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a clone of #2757285: Crop with image_widget_crop save the wrong file path. It's unclear how the underlying problem will be addressed, but this issue can serve as a temporary solution for Image Widget Crop.
Comment | File | Size | Author |
---|---|---|---|
#13 | crop_not_saved_on-2811559-13.patch | 15.25 KB | woprrr |
#10 | crop_not_saved_on-2811559-10.patch | 15.25 KB | woprrr |
#5 | interdiff-crop_not_saved_on-2811559-5.txt | 15.36 KB | woprrr |
#5 | crop_not_saved_on-2811559-5.patch | 15.25 KB | woprrr |
Comments
Comment #2
Algeron CreditAttribution: Algeron at XIO commentedComment #3
Algeron CreditAttribution: Algeron at XIO commentedComment #4
woprrr CreditAttribution: woprrr as a volunteer commentedHii @Algeron
I agree, changing to use insert/update seems like an acceptable workaround to me. But I would do a helper function that you call from insert and update hooks. I find calling hook functions directly always a bit of a code smell.
Comment #5
woprrr CreditAttribution: woprrr as a volunteer commentedhii @Algeron,
Now all is okay for you ? I ve moved the form_submit case too into IWC Manager class. Sadly it's hard to respond all case in 1 function, we need to separate in two methods to manage all cases (Entity approach / Form Api approach (particulary for File Entity case smally complex to manage). I think now we have an more clear / clean code in .module and Code segregation is ok :) In another one issue i think we can increase more the IWC calculation class to split it in interface / class to have an approach more SOLID possible.
Edit : This approach is more Mockable too !! Being able to use dependency injection in places of \Drupal::services() makes me really happy!!!
Comment #8
woprrr CreditAttribution: woprrr as a volunteer commented.... Very strange ... Locally all work / pass I try to re-send...
Comment #9
woprrr CreditAttribution: woprrr as a volunteer commentedComment #10
woprrr CreditAttribution: woprrr as a volunteer commentedThis test fail is an border effect of #2804575: Unchecking "Warn user when a file have multiple usages" seems to have no effect issue. I ve pushed an fixe to fixe that http://cgit.drupalcode.org/image_widget_crop/commit/?id=d1cfdc0
I re-run patch.
Comment #13
woprrr CreditAttribution: woprrr as a volunteer commentedI re run patch !! LAST of the LAST !!
An change in 8.3 in export entity_form / entity_view .... region:xxxxx
It's fixed on dev branch now ...
Comment #15
woprrr CreditAttribution: woprrr as a volunteer commentedComment #16
woprrr CreditAttribution: woprrr as a volunteer commented