Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Algeron created an issue. See original summary.

Algeron’s picture

Algeron’s picture

Status: Active » Needs review
woprrr’s picture

Status: Needs review » Needs work

Hii @Algeron

I agree, changing to use insert/update seems like an acceptable workaround to me. But I would do a helper function that you call from insert and update hooks. I find calling hook functions directly always a bit of a code smell.

woprrr’s picture

hii @Algeron,

Now all is okay for you ? I ve moved the form_submit case too into IWC Manager class. Sadly it's hard to respond all case in 1 function, we need to separate in two methods to manage all cases (Entity approach / Form Api approach (particulary for File Entity case smally complex to manage). I think now we have an more clear / clean code in .module and Code segregation is ok :) In another one issue i think we can increase more the IWC calculation class to split it in interface / class to have an approach more SOLID possible.

Edit : This approach is more Mockable too !! Being able to use dependency injection in places of \Drupal::services() makes me really happy!!!

Status: Needs review » Needs work

The last submitted patch, 5: crop_not_saved_on-2811559-5.patch, failed testing.

The last submitted patch, 5: crop_not_saved_on-2811559-5.patch, failed testing.

woprrr’s picture

.... Very strange ... Locally all work / pass I try to re-send...

woprrr’s picture

Status: Needs work » Needs review
woprrr’s picture

Status: Needs review » Needs work

The last submitted patch, 10: crop_not_saved_on-2811559-10.patch, failed testing.

The last submitted patch, 10: crop_not_saved_on-2811559-10.patch, failed testing.

woprrr’s picture

Status: Needs work » Needs review
FileSize
15.25 KB

I re run patch !! LAST of the LAST !!

An change in 8.3 in export entity_form / entity_view .... region:xxxxx

It's fixed on dev branch now ...

  • woprrr committed 54eba3f on 8.x-1.x
    Issue #2811559 by woprrr, Algeron: Crop not saved on insert when using...
woprrr’s picture

Status: Needs review » Fixed
woprrr’s picture

Status: Fixed » Closed (fixed)