this may relate to: https://www.drupal.org/node/2625032
If I check the "Always expand crop area" box in "Manage form display" on an entity type, save, then create a new instance of that entity type, then select an image through the file browser for the field in question, browse for a file the "CROP IMAGE" widget/box is still closed. I.E. the "Always expand crop area" checkbox configuration appears to be ignored.
I believe that this was working in the past, when I originally set up the module a few months ago. I've noticed some other "Manage form display" configurations not working recently (example: https://www.drupal.org/node/2788905), so maybe something changed in Drupal Core that has rendered these configurations non-functioning.
I think getting this configuration working again would be nice, as its easy for a content creator/editor to miss that cropping functionality when adding/editing content quickly.
Comment | File | Size | Author |
---|---|---|---|
#4 | always_expand_crop-2789547-4.patch | 1.81 KB | woprrr |
Comments
Comment #2
woprrr CreditAttribution: woprrr commentedHii
Sorry for the delay i am verry busy and in holliday actualy. I se this with u thuesday. After you have seen this issue (https://www.drupal.org/node/2752789) ? This patch permit to solve problems beetween crop block area.
Verry THANKS to your feedback / help :)
Comment #3
xeM8VfDh CreditAttribution: xeM8VfDh commentedThanks @woprrr. If you think that other issue covers this, feel fee to close and/or mark as duplicate.
Comment #4
woprrr CreditAttribution: woprrr as a volunteer commentedOk, right !! When i ve process to big refactor i ve missing this functionality VERRY THANK @xeM8VfDh to your feedback. This patch seem fix this issue can you confirm me please ?
Comment #5
xeM8VfDh CreditAttribution: xeM8VfDh commentedThanks @woprrr. Is that patch included in the most current release, or slated for the next release?
Comment #6
woprrr CreditAttribution: woprrr as a volunteer commentedIs available for all versions yes dont worry
Comment #7
xeM8VfDh CreditAttribution: xeM8VfDh commented@woprrr, I updated to Image Widget Crop 8.x-1.3 this morning, and I am still experiencing the issue.
Comment #8
woprrr CreditAttribution: woprrr as a volunteer commented@xeM8VfDh, This morning my patches / updates haven't pushed. But for test this issue you do retreive last version of IWC and donwload the patch of issue and git apply always_expand_crop-2789547-4.patch to test it or in simpletestme with reference to this patch to experiment changes (https://simplytest.me/project/image_widget_crop/8.x-1.3?patch[]=https://...) If all is okay tell me :) For me all is okay on 3 instances.
Comment #9
xeM8VfDh CreditAttribution: xeM8VfDh commentedThanks for the quick responses @woprrr. I will just wait for the fix to be rolled out in the next release
Comment #10
woprrr CreditAttribution: woprrr as a volunteer commentedHii @xeM8VfDh
I think we don't have completely understand is peaps my english (sorry).
To validate and unsure this patch fix your problems i need to other people review that patch to merge this patch in actual release 1.3. Please can you apply this patch on current release an Tell me if ok or not to you ?
I can merge this to release fast after your validation (no few changes is just a bugfix).
Comment #11
woprrr CreditAttribution: woprrr as a volunteer commentedAfter checks with my team in place all is okay i switch to RTBC and merge it to dev. Please can you test in your cases ?
Comment #13
woprrr CreditAttribution: woprrr as a volunteer commentedFixed on Dev branch.
Comment #14
xeM8VfDh CreditAttribution: xeM8VfDh commentedNice, good work! Thanks for the awesome module and for being so responsive!