Double encoding of html characters in attributes when using WYSIWYG, Ckeditor, IMCE (filtered html) [#1774746]

The following theming function encodes the attributes through drupal_attributes().

/**
 * Generate a themed image tag based on an image array.
 *
 * @param $image
 *   An array containing image information and properties.
 * @param $settings
 *   Settings for the input filter.
 */
function theme_image_resize_filter_image($variables) {
  $image = $variables['image'];
  $settings = $variables['settings'];

  $output = '<img' . drupal_attributes($image['attributes']) . ' />';
  if ($image['link']) {
    $output = '<a'. drupal_attributes($image['link']['attributes']) . '>' . $output . '</a>';
  }
  return $output;
}

But what if I add an image attribute through my WYSIWYG, Ckeditor and IMCE setup. It seems to allready insert encoded characters. So if I place this filter on top of this I get double encoding of the attribute values.

My thinking is we should not be using encoding to build our image attributes since something else is allready handling it. So we should just rebuild the array as attributes without encoding...

If I'm right about this I would be glad to supply a patch...

Comment	File	Size	Author
#1	image_resize_filter_no_encoding_of_attributes_1774746_1.patch	1.78 KB	alexverb
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexverb CreditAttribution: alexverb commented 5 September 2012 at 09:24

Status:

Active

» Needs review

File	Size
image_resize_filter_no_encoding_of_attributes_1774746_1.patch	1.78 KB

Added a patch with a small helper function instead of drupal_attributes().

Comment #2

quicksketch

he/him

CreditAttribution: quicksketch commented 5 September 2012 at 21:13

Thanks @alexverb, I think you're right on all counts here. I'll give this a review next time I'm working on Image Resize Filter.

Comment #3

marktheshark CreditAttribution: marktheshark commented 31 October 2012 at 23:14

I have an issue where Insert + Image resize filter appears great in the WYSIWYG editor and upon saving it becomes a partially HTML-escaped mess, e.g.

<p>cxdffd</p><p><img src="/sites/default/files/styles/large/public/images/news/body/dancelife.png\" alt="\&quot;Test\&quot;" title="\&quot;This" width="\&quot;354\&quot;" height="\&quot;98\&quot;" class="\&quot;image-large\&quot;" /></p><p>&nbsp;</p><p>fdfdfd</p><p>&nbsp;</p><p><img src="\&quot;/sites/default/files/styles/large/public/images/news/body/thegshop.jpg&quot;" alt="" width="164" height="60" class="image-large" /></p>

Several backslashes and " symbols don't belong there...

I have "link to original" enabled and the filter is set after the BBCode filter and before everything else.

Is this the same issue?

Comment #4

marktheshark CreditAttribution: marktheshark commented 1 November 2012 at 00:37

Tried the patch. Didn't solve my problem. Still get garbled output:

gdfgd<img src="/sites/default/files/styles/large/public/images/news/body/logo_transparent.png\\" alt="\\"dw\\"" title="\\"eew\\"" width="\\"268\\"" height="\\"170\\"" class="\\"image-large\\"" />gdfgdf <img src="\\"/sites/default/files/styles/large/public/images/news/body/score-big.jpg\"" alt="\"fd\"" title="\"sd\"" width="\"400\"" height="\"300\"" class="\"image-large\"" /> dfgdf <img src="\"/sites/default/files/styles/large/public/images/news/body/mytilinionmap.jpg"" alt="ewr" title="ew" width="212" height="147" class="image-large" />