Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork image_effects-3486314

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

mondrake opened merge request !62

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review

I have resolved the error of PHPCS please review

mondrake’s picture

mondrake
Location 🇮🇹
commented

Thanks @dhruv.mittal! Some of the changes are questionable (constructor description, capital sensitive ordering of use imports), but it's a problem with the coding standards - your work is correct.

Crediting.

  • mondrake committed 04a2a165 on 4.0.x 
    Issue #3486314 by mondrake, dhruv.mittal: Fix CS issues
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.