PHP 7.3 has introduced a change in how continue can be used in a switch. No negative affects on other PHP version from making this change.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3001226-php-7.3-2.patch | 313 bytes | nickdickinsonwilde |
PHP 7.3 has introduced a change in how continue can be used in a switch. No negative affects on other PHP version from making this change.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3001226-php-7.3-2.patch | 313 bytes | nickdickinsonwilde |
Comments
Comment #2
nickdickinsonwildePatch
Comment #3
mondrakeThank you!
Drupal core is not yet supporting 7.3, #2989734: PHP 7.3 compatibility , so we need to wait for that to happen before we can test here.
Comment #4
mondrakeThe core support for PHP 7.3 has been committed, so this one now can move on. Trying a blend of test combinations.
Comment #5
mondrakeLet's wait for the core patch to land also in Drupal 8.6.x then we are ready to re-test and commit.
Works fine down to PHP 5.6; the failure with PHP 5.5 is strange since in fact composer shouldn't even build, but it does on DrupalCI since the info.yml dependencies are required separately from the composer run.
Comment #6
mondrakeComment #9
mondrakeCommitted, thanks!