PHP 7.3 has introduced a change in how continue can be used in a switch. No negative affects on other PHP version from making this change.

CommentFileSizeAuthor
#2 3001226-php-7.3-2.patch313 bytesnickdickinsonwilde

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

Assigned: nickdickinsonwilde » Unassigned
Status: Active » Needs review
StatusFileSize
new313 bytes

Patch

mondrake’s picture

Issue tags: +PHP 7.3
Related issues: +#2989734: PHP 7.3 compatibility

Thank you!

Drupal core is not yet supporting 7.3, #2989734: PHP 7.3 compatibility , so we need to wait for that to happen before we can test here.

mondrake’s picture

The core support for PHP 7.3 has been committed, so this one now can move on. Trying a blend of test combinations.

mondrake’s picture

Let's wait for the core patch to land also in Drupal 8.6.x then we are ready to re-test and commit.

Works fine down to PHP 5.6; the failure with PHP 5.5 is strange since in fact composer shouldn't even build, but it does on DrupalCI since the info.yml dependencies are required separately from the composer run.

mondrake’s picture

mondrake’s picture

Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.