Problem/Motivation

This should be more or less straight port of the 'Define canvas' effect from D7 version of ImageCache actions module.

Proposed resolution

Provide patch and test coverage.

CommentFileSizeAuthor
#7 interdiff_5-7.txt6 KBmondrake
#7 2652898-7.patch46.17 KBmondrake
#5 2652898-5.patch46.17 KBmondrake
#5 interdiff_4-5.txt1.02 KBmondrake
#4 interdiff_2-4.txt6.37 KBmondrake
#4 2652898-4.patch45.15 KBmondrake
#2 2652898-2.patch39.87 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
Issue tags: +Needs tests, +Needs manual testing
StatusFileSize
new 2652898-2.patch39.87 KB

First patch, tests are missing. Takes loads of helpers from Textimage.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2652898-4.patch45.15 KB
new interdiff_2-4.txt6.37 KB

Adding tests, ready for review.

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new interdiff_4-5.txt1.02 KB
new 2652898-5.patch46.17 KB

Adding the effect to the table in README.md

mondrake’s picture

mondrake
Location 🇮🇹
commented
mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 2652898-7.patch46.17 KB
new interdiff_5-7.txt6 KB

Renamed the configuration key 'canvas_mode' to 'canvas_size', to make it more clear what it is about. Possibly in the future this effect may also include a background image to be set as canvas, rather than just the current color/transparency. But I'd leave that to a follow up as this patch is just porting the equivalent effect from ImageCache Actions, and is already big enough.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Patch needed reroll, but it wasn't to bad. Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.