As a failsafe, we should make sure $element['#parents'] exists before we access it. I was getting undefined index errors due to a field that snuck in without #parents being defined.

Patch incoming.

CommentFileSizeAuthor
#21 ife-parents-missing-2341875-21-D7.patch365 bytesandrefy
#17 ife-parents-missing-2341875-17-D7.patch467 bytesomarlopesino
#13 ife-parents-missing-2341875-13-D7.patch466 bytesomarlopesino
#12 ife-parents-missing-2341875-12-D7.patch467 bytesomarlopesino
#5 7.x-2.x-dev-parents-missing-2341875-3.patch2.85 KBqzmenko
#1 2341875-1-ife-parents-missing.patch438 bytesmcrittenden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcrittenden’s picture

mcrittenden CreditAttribution: mcrittenden commented
FileSize
2341875-1-ife-parents-missing.patch438 bytes

Attached patch is against 2.0-alpha2. Will probably have to be re-rolled for latest dev.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Active » Needs review
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko commented

delete.

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko commented
Version: 7.x-2.0-alpha2 » 7.x-2.x-dev
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko at DrupalJedi commented
FileSize
7.x-2.x-dev-parents-missing-2341875-3.patch2.85 KB

This problem is repeated in the dev. The patch which was posted by mcrittenden does not work with the dev version of the module. I'm attaching a patch for the dev version.

  • ram4nd committed d5ee80c on 7.x-2.x authored by qzmenko 
    Issue #2341875 by qzmenko, mcrittenden: Undefined index error due to...
ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

mcrittenden's patch was applied to dev, and to quote mcrittenden: "Attached patch is against 2.0-alpha2. Will probably have to be re-rolled for latest dev."

Patch in #5 is probably what is needed.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
Priority: Normal » Critical

Setting to critical, since I can't reopen the ticket. This broke ife.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Closed (fixed) » Active
omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino as a volunteer and at Metadrop commented
FileSize
ife-parents-missing-2341875-12-D7.patch467 bytes

Attach a reroll, please review!

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino as a volunteer and at Metadrop commented
FileSize
ife-parents-missing-2341875-13-D7.patch466 bytes

Sorry! That reroll was wrong, uploading correct.

  • ram4nd committed 38b891d on 7.x-2.x authored by mistermoper 
    Issue #2341875 by mistermoper, qzmenko, mcrittenden: Undefined index...
ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino as a volunteer and at Metadrop commented
FileSize
ife-parents-missing-2341875-17-D7.patch467 bytes

That patch breaks some use cases in inline form errors. The function must exit only when #parents is not set (it can be empty, and that is correct).

I can't change issue status, this issue needs review.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Closed (fixed) » Needs work

Your patch doesn't run against latest dev branch.

andrefy’s picture

andrefy CreditAttribution: andrefy as a volunteer and commented

This patch is breaking is also braking for me some uses cases in inline form errors, I am working on the 7.x-2.x-dev

ShaneOnABike’s picture

ShaneOnABike CreditAttribution: ShaneOnABike commented

I can confirm that changing the code to isset returns this module back to functionality. The empty flagged introduced completely broke things.

andrefy’s picture

andrefy CreditAttribution: andrefy as a volunteer and commented
FileSize
ife-parents-missing-2341875-21-D7.patch365 bytes

This is an update of path #17 for the latest version of 7.x-2.x-dev

andrefy’s picture

andrefy CreditAttribution: andrefy as a volunteer and commented
Status: Needs work » Needs review
mtem27’s picture

mtem27 CreditAttribution: mtem27 commented

Patch from #21 works for me in 7.x-2.x-dev version.

TVoesenek’s picture

TVoesenek CreditAttribution: TVoesenek commented
Status: Needs review » Reviewed & tested by the community

I can confirm te patch from #21 solves this problem on the latest 7.x-2.x dev and 7.x-2.0-alpha3 release (which now has broken functionality).

  • ram4nd committed 8db6704 on 7.x-2.x authored by andrefy 
    Issue #2341875 by mistermoper, qzmenko, andrefy, mcrittenden, ram4nd:...
ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.