Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This issue is for catching the changes that have happened since the start of the conversion for Drupal 8.
There are at least 2 issues:
* The initial conversion was made using DrupalModuleUpgrader module. Since the initial port that module has had some updates and catches a few more changes that need to be made.
* 7.x had additional features after the initial conversion. For instance the ability to put a wrapper around icons.
The plan is to generate a patch for 8.x-dev which captures these changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | incorporating-7.x-updates-into-8.x-2863487-16.patch | 41.58 KB | Jeff Veit |
| #10 | incorporating-7.x-updates-into-8.x-2863487-10.patch | 37.52 KB | Jeff Veit |
| #6 | incorporating-7.x-updates-into-8.x-2863487-6.patch | 56.36 KB | Jeff Veit |
| #4 | patch3.patch | 56.36 KB | Jeff Veit |
| #3 | patch2.patch | 42.36 KB | Jeff Veit |
Comments
Comment #2
Jeff Veit CreditAttribution: Jeff Veit commented1st step/patch. It's here to show some history and working, but it's not interesting in itself. It'll be incorporated in a later patch.
It takes the 7.x version of the module used as the basis of the 8.x module, runs it through DrupalModuleUpgrader as it now stands, and merges with all the changes in the 8.x-dev module at e9b19b38 - i.e. after the original DrupalModuleUpgrader update to 8.x. So it represents how 8.x would have been initially if the current DrupalModuleUpgrader module had been used.
Comment #3
Jeff Veit CreditAttribution: Jeff Veit commentedMore working. This is 7.x-1.x upgraded using DrupalModuleUpgrader.
Comment #4
Jeff Veit CreditAttribution: Jeff Veit commentedThis patch contains all the changes of the previous two, against 8.x-dev, resolving the issues originally listed.
It still has lots of FIXME's generated by the DrupalModuleUpgrader auto upgrade but it's contains the functionality of 7.x-1.0 + 8.x-dev changes + enhanced auto upgrade changes.
It will have to be re-rolled since there's been a new 8.x-1.x version while I was working on it.
Comment #5
Jeff Veit CreditAttribution: Jeff Veit commentedIt won't have to be rerolled yet. The change I saw was a patch, not a repo change.
Comment #6
Jeff Veit CreditAttribution: Jeff Veit commentedSame patch, now with a more sensible file name.
Comment #7
markhalliwellThis is reverting the
icon_fieldwork that was already committed from #2529032-23: Upgrade To Drupal 8.Comment #8
Jeff Veit CreditAttribution: Jeff Veit commentedThanks, I'll have a look.
Comment #9
Jeff Veit CreditAttribution: Jeff Veit commentedThanks, I'll have a look.
Comment #10
Jeff Veit CreditAttribution: Jeff Veit commentedYup. That last one was still a work in progress, as is this one, but it merges in the the changes already committed to the 8.x-1.x branch - i.e the work on fields.
In this version there are still the numerous FIXMEs introduced by the auto upgrade. Dealing with those is the next job.
Comment #11
sylus CreditAttribution: sylus commentedComment #12
sylus CreditAttribution: sylus commentedLooks like I am going to need this in order to continue my work on annotations.
#2863343: Create plugin managers for existing procedural D7 API
Would this also be the right place to take into account:
#2135291: [Policy, no patch] PHP 5.4 short array syntax coding standards for Drupal 8 ?
Comment #13
Jeff Veit CreditAttribution: Jeff Veit commentedWe could combine now. It's not working yet but if we put it all on github, then we can use git to bring it all up to date.
Or if you are using git - I can give you the repo I'm using. That would give us the same history and would mean it's easier to merge separate strands later on.
I haven't been doing coding standard fixes or prettyfying, but I could. However I'm probs not going to be able to work on it this weekend: seriously ill relative.
Comment #14
sylus CreditAttribution: sylus commentedNo worries appreciate your help!
I think @markcarver wanted us to stick to the patch workflow though.
I'll probably take your patch currently posted here and just complete what is left as I think there are only a few @FixMe's to do. Will of course leave attribution to you :)
Comment #15
Jeff Veit CreditAttribution: Jeff Veit commentedI'm still saying to make patches so that Mark and others can track. It's just that it's easier if you have the repo.
I've got a few more changes made after the last patch - I was starting on FIXME items.
Patch in a minute or few...
Comment #16
Jeff Veit CreditAttribution: Jeff Veit commentedSmall changes but related to the discovery.
Patch against the current 8.x-1.x.
Comment #17
markhalliwellFWIW, I'm ok with the current @FIXEME comments. The primarily goal of this issue (in my mind) is to merge in the wrapper changes from 7.x. Since this does that, I'd say we can go ahead and commit.
@Jeff Veit, once you're done, please un-assign and set the status to needs review.
@sylus, please review and merge once you're satisfied with the result.
Comment #18
Jeff Veit CreditAttribution: Jeff Veit commentedI can carry on with FIXMEs in another thread. The main merge is done. Unassigning and setting to needs review now.
Comment #19
Jeff Veit CreditAttribution: Jeff Veit commentedComment #21
sylus CreditAttribution: sylus commentedI tested this on my local with no problems. ^_^
Only noticed a few minor nits + whitespace so made the adjustments.
Committed and attributed, thank you so much for taking the time!
Minor correction to yml to include ':'
Minor spelling nit.