hook_page_build() is gone -- see this CR: https://www.drupal.org/node/2357755

hook_page_attachments() or hook_page_bottom() look like the best candidates to replace this with.

CommentFileSizeAuthor
#13 replace-hook-page-build-with-hook-page-attachments-3048150-13.patch8.5 KBamarphule
#10 interdiff_8-10.txt1.01 KBamarphule
#10 replace-hook-page-build-with-hook-page-attachments-3048150-10.patch6.44 KBamarphule
#8 replace-hook-page-build-with-hook-page-attachments-3048150-8.patch6.64 KBamarphule
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amarphule created an issue. See original summary.

rahul.shinde credited BramDriesen.

rahul.shinde credited ZhuRenTongKu.

rahul.shinde credited mmjvb.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented

rahul.shinde credited f2boot.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented
Issue tags: +#d8port
amarphule’s picture

amarphule CreditAttribution: amarphule at DevsAdda for DevsAdda commented
Assigned: amarphule » Unassigned
Category: Feature request » Task
Status: Active » Needs review
Parent issue: » #3012400: [hypothesis] Hypothesis
FileSize
replace-hook-page-build-with-hook-page-attachments-3048150-8.patch6.64 KB

Replaced the hook_page_build() with hook_page_attachments. See the CR https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented
Status: Needs review » Needs work

Review of #8.

  1. +++ b/hypothesis.module
@@ -2,80 +2,73 @@
+  foreach ($default_behaviors as $key => $default_behavior) {

    Remove this. As we have defined config for this which has the default values I believe, so no need to re-iterate. 

  2. +++ b/hypothesis.module
@@ -2,80 +2,73 @@
+  $attachments['#attached']['drupalSettings']['hypothesis'] = $default_behaviors;

    Replace $default_behaviors with $config->get('behavior');
    And remove this $default_behaviors = $config->get('behavior');

amarphule’s picture

amarphule CreditAttribution: amarphule at DevsAdda for DevsAdda commented
Status: Needs work » Needs review
FileSize
replace-hook-page-build-with-hook-page-attachments-3048150-10.patch6.44 KB
interdiff_8-10.txt1.01 KB

Updated .module file as suggested in comment #9. And added interdiff.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented

@amarphule, please have config schema changes here as those changes are apt and should go with this ticket. Here is the comment issues-3048147#comment-13077908

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented
Status: Needs review » Needs work
amarphule’s picture

amarphule CreditAttribution: amarphule at DevsAdda for DevsAdda commented
Status: Needs work » Needs review
FileSize
replace-hook-page-build-with-hook-page-attachments-3048150-13.patch8.5 KB

updated hook_page_attachments(). updated config schema. added dependencies in libraries.yml.
Changed Unicode::* methods to mb_* functions as per https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda for HighWire Press, Inc commented
Status: Needs review » Fixed

Patch merged to 8.x-1.x branch. @amarphule thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.