It should be a simple humanstxt.schema.yml file defining the content and display_link settings schema.

CommentFileSizeAuthor
#9 add_schema_for_module_settings_3123129_9.patch580 bytesdavidjguru
#9 humanstxt_config_inspector_feedback.png28.87 KBdavidjguru
#4 add_schema_for_module_settings_3123129_4.patch556 bytesdavidjguru

Comments

pcambra created an issue. See original summary.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Issue tags: +Newbie
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
commented
Assigned: Unassigned » davidjguru
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
commented
StatusFileSize
new add_schema_for_module_settings_3123129_4.patch556 bytes

Hi, I've just upload a patch creating this kind of file for the humanstxt settings.

Greetings,
David.

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
commented
Assigned: davidjguru » Unassigned
Status: Active » Needs review
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Looks good, have you checked with https://www.drupal.org/project/config_inspector?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented 
+++ b/config/schema/humanstxt.schema.yml
@@ -0,0 +1,11 @@
+      type: string

Should this be translatable at all? not 100% sure

https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
commented

Hi, I don't know about this resource...I'll test the config_inspector contrib module.
About the translation, I didn't think so, but I can change the code and add the translation key, for sure.

I'll make a new patch.

Greetings,

David.

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
commented
StatusFileSize
new humanstxt_config_inspector_feedback.png28.87 KB
new add_schema_for_module_settings_3123129_9.patch580 bytes

Hi, I just reload a new version of the patch, testing it with the config_inspector contrib module (Here the feedback from the UI).
Humanstxt config inspector feedback

I've changed the type: string for the type:text, based in the recommended type for long strings:
https://git.drupalcode.org/project/drupal/blob/8.0.x/core/config/schema/core.data_types.schema.yml#L500

In order to avoid future confussions using the tag "label", I've used the explicit form of the translation key, this is:

type: text
translatable: true

instead of:
type: label

Greetings,
David.

  • pcambra committed cde564e on 8.x-1.x authored by davidjguru 
    Issue #3123129 by davidjguru: Add a schema for the module settings
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Awesome, many thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.