Altering the values found in the filter configuration screen does not save the new settings. Looking at the code, it seems there are no variable_set functions being called.

Even with the default settings, the module does not perform any of the HTML Tidy functions specified. (the module did find the Tiny binary though).

I'm not sure if this module is ready to be out of DEV yet.

CommentFileSizeAuthor
#2 htmltidy-607384-2.patch1.42 KBheltem
#1 htmltidy-607384.patch282 bytesheltem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heltem’s picture

heltem CreditAttribution: heltem commented
Status: Active » Needs review
FileSize
htmltidy-607384.patch282 bytes

Hi,

Settings are well saved but not well displayed afterwards because the default value overwrites the saved value when it is considered empty like 0 or null.

Please review.

heltem’s picture

heltem CreditAttribution: heltem commented
FileSize
htmltidy-607384-2.patch1.42 KB

Some missing settings were not fixed in my previous patch.

michaelfavia’s picture

michaelfavia CreditAttribution: michaelfavia commented
Status: Needs review » Fixed

Thankyou for the patch fix in dev branch. Rolling a release now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.