Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Looks like this module made for drupal 5.x
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | htmltidy.patch | 7.23 KB | vectoroc |
| #8 | htmltidy.patch | 7.2 KB | vectoroc |
| #6 | htmltidy.patch | 4.1 KB | vectoroc |
| #1 | htmltidy.patch | 4.01 KB | vectoroc |
Comments
Comment #1
vectoroc CreditAttribution: vectoroc commentedIts work for me. Need some testing.
Comment #2
jubalkessler CreditAttribution: jubalkessler commentedGot this when running the latest version (6.x-1.0):
warning: Missing argument 1 for htmltidy_menu() in /sites/museum/modules/htmltidy/htmltidy.module on line 34.
Seems to be part of this patch.
Suggestions?
Comment #3
michaelfavia CreditAttribution: michaelfavia commentedwill look at and commit tomorrow for you.
Comment #4
Jax CreditAttribution: Jax commentedThe hook_menu is implemented as it was in D5. That should be removed from the patch.
Comment #5
lavamind CreditAttribution: lavamind commentedReverting the menu makes the error message go away, but the module doesn't work at all for me, using Drupal 6.13. I see "Array" on top of all my pages when the filter is active, and filtered node content doesn't appear.
Comment #6
vectoroc CreditAttribution: vectoroc commentedwrong patсh
there is patсh which make my fixed file to old original :)
sorry for mistake
Comment #7
vectoroc CreditAttribution: vectoroc commentedI use that through monkey path. At begin of page.tpl insert ob_start(), at end - print htmltidy_string( ob_get_clean() )
Comment #8
vectoroc CreditAttribution: vectoroc commentedThere is new path which supports drupal 6.x filters
Comment #9
vectoroc CreditAttribution: vectoroc commentedI found bug in patch. There is fixed.
Comment #10
jsgammato CreditAttribution: jsgammato commentedIs there a way for a non-developer user to use this patch? Or do we have to wait for a build?
I don't mind carefully copying and pasting code, but that's about the limit of my skill!
Comment #11
vectoroc CreditAttribution: vectoroc commentedhttp://drupal.org/patch/apply
It is simple ;)
Comment #12
glass.dimly CreditAttribution: glass.dimly commentedHi folks,
I'm changing this to a bug report. It's obviously critical because it impairs the module from functioning without the application of a patch.
Can someone with commit access roll this into a release?
thanks,
glass.dimly
Comment #13
glass.dimly CreditAttribution: glass.dimly commentedThis patch doesn't fully add D6 support.
It eliminates the above error, but navigating to admin/settings/htmltidy still produces no configuration page. Copying the htmltidy library to modules/htmltidy/bin likewise has no effect on the module configuration page.
There is an HTMLtidy input filter, but has no configuration options.
It's a great thing to release a module that is still in development, but please use the "dev" release so that you don't "break the Drupal" of unsuspecting newbies.
Comment #14
vectoroc CreditAttribution: vectoroc commenteddid you enable a module through drush? Try to reenable htmltidy from admin/build/modules.
http://skitch.com/vectoroc/nnica/html-tidy-tree.local
Comment #15
glass.dimly CreditAttribution: glass.dimly commentedI did enable it through Drush.
You're right, when I just now enabled it normally, it did display configuration pages. I'm moving this bug back down to normal and will let others take it from here.
I was using HTML Tidy to fix a bug in WYSIWYG, but I ended up switching from WYSIWYG to FCKeditor, so I don't really need Tidy for the moment, but thanks for taking to time to respond to my post.
Comment #16
michaelfavia CreditAttribution: michaelfavia commentedD6 support was fully integrated into the dev branch for d6 in CVS but i failed to make a release node for it. I apologize for that it was my mistake. I have posted it on the porject page now and will happily accept patches for improvement. ill be available in IRC this week if anyone needs me or just opena new issue with specific concerns on the project page.