Automated Drupal 10 compatibility fixes

These changes look reasonable, I haven't seen the bot fail yet.

When I apply #2 patch.
Patch apply cleanly but I got 2 errors and 1 warning(see attached screenshot) when HTML Mail module check on Upgrade Status module.
So, I create MR for that.
Please review this MR.

Thanks

MR on #10 works for me , issues have gone.

Sorry for the multiple push. I squashed my commits into one.

Their was an issue with a deprecated function call "system_sort_modules_by_info_name" (see https://www.drupal.org/node/3225999) fixed in the branch.

-core_version_requirement: ^8.8.2 || ^9
+core_version_requirement: ^8.8.2 || ^9 || ^10

This is wrong. Just as one example, it is incompatible with this change:
The function system_sort_modules_by_info_name() is deprecated.
because that change will break this module if installed on D8.8.2, D8.9, D9.0, D9.1, or D9.2.

Rather than spend time trying to port this module to D10 when it doesn't even work properly in D9, I would like to see get community help for a long-term solution. Please comment in #3339287: The future of the HTML Mail module if having HTML mail support in Drupal 10 is important to you.

I have tested MR in #10 with D9 and D10 both, working fine for me and making module D10 compatible. Upgrade status is also showing no error found.

Moving this to RTBC for D10 compatible stable release.

Hi,

Is it still possible to release Drupal 10 version? Here is the patch with changes I saw that was needed. In our case we just need to upgrade whole project to Drupal 10 and moving functionality to mimemail module is not reasonable.

@TR, the solution you suggested seems to be to change this:
core_version_requirement: ^8.8.2 || ^9 || ^10

to this:
core_version_requirement: ^9.3 || ^10

once this change is made to the merge request htmlmail.info.yml file, I think we can put this back to RTBC

as for the module as a whole, it would be good to merge the upgraded code which will allow people to swallow moving to another mail solution some time after their D10 upgrade.

Lets make the transition to D10 a bit easier for people, as it's already a significant upgrade to deal with.

With that said, I don't see why we have to restrict ourselves and others to only one possible mail solution regardless of the obvious benefits of that there's also some discomfort involved in switching.

Beside that, I haven't looked at all the positives and negatives in comparison to symfony mailer. Does the symfony mailer support theming in a friendly way as this one does? Not sure.

Or create a 4.x branch for D10 and keep 8.x-3.x available for D8/9?

I sympathize with #17 and #18, and I've created a new branch 4.x for D10 compatibility.

This issue is a mess. Please provide a combined patch including #4, #12, #16, and (if possible) remove the guessMimeType() hack, against 4.x-dev.

Patch for comment #13 made against the 4.x-dev branch.

After using this issue repo
D10 site throws

TypeError: Drupal\htmlmail\Plugin\Mail\HtmlMailSystem::__construct(): Argument #10 ($mimeTypeGuesser) must be of type Symfony\Component\HttpFoundation\File\MimeType\MimeTypeGuesserInterface, Drupal\Core\ProxyClass\File\MimeType\MimeTypeGuesser given, called in /modules/custom/htmlmail/src/Plugin/Mail/HtmlMailSystem.php on line 147 in Drupal\htmlmail\Plugin\Mail\HtmlMailSystem->__construct() (line 109 of modules/custom/htmlmail/src/Plugin/Mail/HtmlMailSystem.php).

Oh! mistakenly tested 8.x-3.x
3287920-automated-drupal-10 branch doesn't show that issue

I merged MR !2 into !5 targetting 4.x, and fixed the core_version_requirement conflict, setting it to D9 and D10 as per #18. Setting it for D10 only is a bad idea because it requires folks to upgrade Drupal core and this contrib module at the same time, which I don't recommend.

Assuming there are no other problems, MR !5 is good to go. Please review.

Maintainers: If you'd like help with getting this out (merging & cutting a new release), please add me as a co-maintainer; I'll get it done.

After this gets in, we really should focus on #3339287: The future of the HTML Mail module next.

I am getting the following error:

TypeError: Drupal\htmlmail\Plugin\Mail\HtmlMailSystem::__construct(): Argument #10 ($mimeTypeGuesser) must be of type Symfony\Component\Mime\MimeTypesInterface, Drupal\Core\ProxyClass\File\MimeType\MimeTypeGuesser given, called in /var/www/html/docroot/modules/contrib/htmlmail/src/Plugin/Mail/HtmlMailSystem.php on line 147 in Drupal\htmlmail\Plugin\Mail\HtmlMailSystem->__construct() (line 109 of /var/www/html/docroot/modules/contrib/htmlmail/src/Plugin/Mail/HtmlMailSystem.php).

I am trying to supply a patch that will fix this issue.

@chadmandoo: Please push to the MR as well so that it stays up-to-date. Thanks!

The MR looks good! Upgrade patch got applied cleanly to 'composer require drupal/htmlmail:4.x-dev#9abc3ae', using https://git.drupalcode.org/project/htmlmail/-/merge_requests/5.diff

MR 5 by @colan is good

we're using it like this:

dbd771f3

in the repositories section of the composer.json:

        "0": {
            "type": "package",
            "package": {
                "name": "drupaloverride/htmlmail",
                "version": "dev-1",
                "type": "drupal-module",
                "dist": {
                    "type": "zip",
                    "url": "https://git.drupalcode.org/api/v4/projects/project%2Fhtmlmail/repository/archive.zip?sha=dbd771f3"
                }
            }
        },

Then:
composer require drupaloverride/htmlmail

MR 5 was merged in, we've been using it for quite some time.

With that said, here's the rankings in popularity for html mailers:

1. mimemail 64000+ installs , 24000+ installs for Drupal 8 and about 40,000 installs for Drupal 7.
2. Swiftmailer 27,400 + installs deprecated by symfony_mailer
3. Symfony_mailer 23000+ installs
4. in last place: htmlmail

21,040 installs, 3000 installs on Drupal 8/9/10, 17000 on D7

Here's a dev release
https://www.drupal.org/project/htmlmail/releases/4.0.x-dev

With that said, please consider switching to Symfony_mailer or mimemail.

There's still 21000 installs of htmlmail currently.