i installed the htmlarea into a my drupal cvs test directory and i seem to be running into some problems or possible bugs.

The first one is that the name "htmlarea" did not show up in the configuration > modules table. the description did but the name was blank. i went into the htmlarea module and changed this line,

10 $output .= t("htmlarea#name");

to

10 $output .= t("htmlarea");

reloaded the modules page and a few things changed. now the name shows up and the "htmlarea" module is listed as a node under the modules tree (it wasn't before this time) even though i had enabled the html module (btw i did copy all the files to "misc/htmlarea"). i went to create content > story and the html area did not show up as previous versioni (4.2). i went back and clicked on the module > htmlarea and a settings page came up. i clicked save configuration and i received this error:

Fatal error: Call to undefined function: system_save_settings() in D:\FoxServ\www\test\modules\htmlarea.module on line 39

i did a search on the htmlarea.module for this function and could not find it. i went to the cvs root directory and did a search and could not find it there either. i went to a 4.3.2 directory and did a search and found the function in system.module which is not part of the cvs distro.

i went as far as to copy those functions into the htmlarea.module and still no success. i give up. and asking for help here. could you tell me what i am doing wrong?

judah

CommentFileSizeAuthor
#3 0193.HEAD.gordon.system-fix-modules_name.patch1.24 KBgordon
#2 htmlarea.php5.62 KBjudah
#1 0193.HEAD.gordon.system-fix-modules#name.patch1.24 KBgordon

Comments

gordon’s picture

gordon commented
StatusFileSize
new 0193.HEAD.gordon.system-fix-modules#name.patch1.24 KB

I have removed the #name section all together as the cvs version doesn't work properly with it. I have attached an interim patch that fixes this problem and then will be removed when the _system() hook will be completely removed along with thei hook.

judah’s picture

judah commented
StatusFileSize
new htmlarea.php5.62 KB

thank you for your prompt reply. i cant access the attachment (page not found). but if from what i understnad from your message that doesn't matter because the module still needs additional updates to work (ie the save_system_settings()).

i'm curious, on the cvs release there is no drupal.diff in the directory. the install instructions for the cvs version do not mention it either. in versions up to 4.3 (htmlarea.module dated 11.21.2003) this was included. i never applied it in the past. i did everything else,
- included the htmlarea.module in modules directory
- copied the htmlarea files to the misc/htmlarea directory
- applied the htmlarea.sql update to drupal database

i did not apply the drupal.diff because i have no idea how. i read through the docs multiple times (i'm on a windows machine)and i dont know, i think there has got to be a better way. i may be dense but i have been programming for 6 years now and i can't figure out what to do. regardless, even *without* this drupal.diff file applied the htmlarea worked in most cases. occasionally bugs would pop up so i never used html area on a production server but locally it worked 80% of the time without mentioning any bugs.

what i want to know is should this drupal.diff be included with the cvs distro? also, i created a personalized php update page for applying .sql updates. your htmlarea is the first to use. it works just like the update.php file. what it does different is that it only includes sql to update your htmlarea and not anything else. i did this because it makes everything easier and i like easier. for real though, i have a remote server and it would be easier to run this page then login to a database manager and run the script. anyway, i could go on on how i think it is easier and blah blah blah but you can assess that for yourself. if you want to take this page and let any other mod writers use it they can. i will update it, make it easier, (you know, turn it into a template type file) and provide docs on how to use it. i've only tested it once with htmlarea.sql. i dont know php but i fidgeded around with it and somehow it works. i would need help if i got much deeper into it.

suggestion: the drupal.diff thing is way to confusing. i read through the docs multiple times and i dont know i think there has got to be a better way. there can definately be a simpler way. i read through the file and it looks like it adds new functions and maybe updates other functions. i suggest putting all the function updates into a file and then giving some instructions to where to copy them.
----------------------------------------------------------
II. instructions for function updates
- open system.module in text editor
- open drupal.diff doc in text editor
- copy functions 1,2,3...etc to end of system.module file
- save and exit system.module
you are now ready to go onto the next step.
III. applying the sql update
- copy htmlarea.php to server
- open in browser
- follow on screen instructions
IV. next step...
-----------------------------------------------------------

how can i help this along?

gordon’s picture

gordon commented
StatusFileSize
new 0193.HEAD.gordon.system-fix-modules_name.patch1.24 KB

The call to system_save_settings() has been fixed in cvs, and I have check 4.3.x whcih seems to work as well.

There is no diff to cvs aka 4.4.0 as this diff has been patched into the cvs version of drupal. so you don't need to do anything. except install htmlarea onto your drupal cvs(4.4.0) system

If you want I can upload the 2 files to my web server so you can download them, then you do not need to apply the patch, just copy in the files from my web site.

The most important thing to remember is not to cross the version of htmlarea with the wrong version of drupal. the cvs version will not work properly (if at all) with drupal 4.3.x and the 4.3.x version of htmlarea will not work properly with the cvs version of drupal.

As for the drupal.diff, it is the way that most drupal and unix programmers create patches. read http://drupal.org/book/view/324 which explains how to use cvs, diff, and patch on windows.

I have also fixed up the download patch, the # was stuffing things up.

Anonymous’s picture

(not verified) commented