Are there intentions to continue development of this project?

CommentFileSizeAuthor
#4 combine_audio_fields-1230966-comment-4914498.patch9.28 KBbhosmer
#3 combineaudiofields-1230966-2.patch0 bytesbhosmer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

travist’s picture

travist CreditAttribution: travist commented
Status: Active » Closed (fixed)

Yes, definitely. I will be jumping back on this project within the next couple of weeks since I have been consumed with a different project at the moment.

bhosmer’s picture

bhosmer CreditAttribution: bhosmer commented

Right on! I'm working on a patch to combine the displays. Good to hear from you Travis.

bhosmer’s picture

bhosmer CreditAttribution: bhosmer commented
Category: support » feature
Status: Closed (fixed) » Patch (to be ported)
FileSize
combineaudiofields-1230966-2.patch0 bytes

As the result of the Brevard Drupal meetup, we worked on combining the display of fields for cross-browser compatibility. Chrome supports mp3 and ogg, firefox only supports ogg, and safari only supports mp3.

Two files are needed when adding an audio upload and now with this patch you upload both and the HTML is output like this:

<audio>
<src>
<src>
</audio>

With this patch it is important that the first file be the mp3 and then the second be the ogg, otherwise safari will not process the audio files.

Thanks to @ultimike for his help with this during the meetup.

bhosmer’s picture

bhosmer CreditAttribution: bhosmer commented
FileSize
combine_audio_fields-1230966-comment-4914498.patch9.28 KB

That first one was empty, this patch should work now:

travist’s picture

travist CreditAttribution: travist commented

Thanks for this. I will definitely look it over.

I did take a quick glance and noticed that the patch removes a lot of my recent work on implementing a standard media player for browsers with JS enabled. Was this intentional? If not, then I can do a quick diff between this and my current version to see how I can incorporate the changes.

Also, tell Michael (ultimike) that I said hello. :)

Travis.

bhosmer’s picture

bhosmer CreditAttribution: bhosmer commented

I must not have seen the recent update you did. No, I did not intend to override the recent media player updates.

I'll pass on the greetings to Mike.

You'll see that I added a checkbox to the menu, "combine" that doesn't actually do anything yet. It was a work in progress just in case users might not want to actually combine the displays.

I wasn't sure about the best way to implement this.

ebieymjunior’s picture

ebieymjunior CreditAttribution: ebieymjunior commented

Does this module work with the Media module?

Thanks

travist’s picture

travist CreditAttribution: travist commented

Yes. It works nicely since all it really does is create a field formatter for displaying files as Media within a player. Since Media just uses fields, this module should work fine with the Media module.

ebieymjunior’s picture

ebieymjunior CreditAttribution: ebieymjunior commented

Thanks for the quick answer!

travist’s picture

travist CreditAttribution: travist commented
Status: Patch (to be ported) » Fixed

So, I know that this is an old thread, but I have made a big improvement to how this module handles both audio and video as if they are equal. Please try the latest version and let me know if that satisfies the work done with the patches made.

Also, I will be submitting a core patch within a week where this module will simply be a drupal 7 version of that d8 patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.