It's currently theoretically possible to configure HP, enable it, and then remove the API key, causing the JavaScript added to the page to receive an empty API key parameter. We should at least ensure it isn't empty when we try to add the JavaScript even if we don't have a fast way to validate it's a legitimate key.

CommentFileSizeAuthor
#2 2921637-2.hp_js_api_key.patch918 bytesrszrama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama created an issue. See original summary.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro commented
Status: Active » Needs review
FileSize
2921637-2.hp_js_api_key.patch918 bytes

Patch attached.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro commented
Status: Needs review » Fixed

Committed.

  • rszrama committed 21a20f7 on 7.x-1.x 
    Issue #2921637 by rszrama: don't include the HP JavaScript if we can't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.