Changed permissions of                                               [success]
/var/aegir/.drush/server_master.alias.drushrc.php to 440 [53.26 sec,
9.3 MB]
Returned from hook drush_provision_save [53.26 sec, 9.3 MB]              [debug]
Returned from hook drush_provision_save [53.26 sec, 9.3 MB]              [debug]
Command dispatch complete [53.26 sec, 9.22 MB]                          [notice]
Command dispatch complete [53.26 sec, 9.22 MB]                          [notice]
Undefined property: stdClass::$task_command task.hosting.inc:160        [notice]
[53.27 sec, 24.56 MB]
Undefined property: stdClass::$task_command task.hosting.inc:160        [notice]
[53.27 sec, 24.56 MB]
Backend invoke: /usr/bin/drush  --backend=2 --verbose --debug --yes    [command]
@server_master  2>&1 [53.27 sec, 24.57 MB]

...

Changed permissions of /var/aegir/hostmaster-7.x-3.140/sites/aegir.example.com/drushrc.php to 640                                                                                                                                                                            [success]
Generated config in write(): Site Drush configuration file (/var/aegir/hostmaster-7.x-3.140/sites/aegir.example.com/drushrc.php)                                                                                                                                             [success]
Changed permissions of /var/aegir/hostmaster-7.x-3.140/sites/aegir.example.com/drushrc.php to 440                                                                                                                                                                            [success]
Platforms path /var/aegir/platforms exists.                                                                                                                                                                                                                                     [success]
Platforms ownership of /var/aegir/platforms has been changed to aegir.                                                                                                                                                                                                          [success]
Platforms permissions of /var/aegir/platforms have been changed to 755.                                                                                                                                                                                                         [success]
Platforms path /var/aegir/platforms is writable.                                                                                                                                                                                                                                [success]
Generated config in write(): Drupal sites.php file (/var/aegir/hostmaster-7.x-3.130/sites/sites.php)                                                                                                                                                                            [success]
Changed permissions of /var/aegir/hostmaster-7.x-3.130/sites/sites.php to 644                                                                                                                                                                                                   [success]
'drush' cache was cleared.                                                                                                                                                                                                                                                      [success]
This command will replace your crontab for this user. continue? (y/n): y
/usr/bin/env php /usr/local/bin/drush '@hostmaster' hosting-dispatch 
Dispatch command was run successfully                                                                                                                                                                                                                                           [success]
Adding hosting-dispatch cron entry to run every minute                                                                                                                                                                                                                          [ok]
Installed a new crontab entry.                                                                                                                                                                                                                                                  [success]
Changed permissions of /var/aegir/.drush/server_master.alias.drushrc.php to 640                                                                                                                                                                                                 [success]
Generated config in write(): Drush configuration file (/var/aegir/.drush/server_master.alias.drushrc.php)                                                                                                                                                                       [success]
Changed permissions of /var/aegir/.drush/server_master.alias.drushrc.php to 440                                                                                                                                                                                                 [success]
Could not find a Drupal settings.php file at sites/default/settings.php.                                                                                                                                                                                                        [error]
dpkg: error processing package aegir3-hostmaster (--configure):
 subprocess installed post-installation script returned error exit status 1
dpkg: dependency problems prevent configuration of aegir3:
 aegir3 depends on aegir3-hostmaster (>= 3.140); however:
  Package aegir3-hostmaster is not configured yet.

dpkg: error processing package aegir3 (--configure):
 dependency problems - leaving unconfigured
Processing triggers for systemd (232-25+deb9u1) ...
Errors were encountered while processing:
 aegir3-hostmaster
 aegir3

Could this be a side effect of #2912492: Allow hook_hosting_tasks to specify "command" ?

CommentFileSizeAuthor
#2 2942500-hotfix-task-command.patch579 byteshelmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

helmo created an issue. See original summary.

helmo’s picture

Here's a hotfix for the hosting module ... it needs more testing.

helmo’s picture

An other option would be to add this code (from hosting_task_load) also in drush_hosting_task_validate where the task node is created.

    // Invoke hook_hosting_tasks().
    $types = module_invoke_all('hosting_tasks');
    // Invoke hook_hosting_tasks_alter().
    drupal_alter('hosting_tasks', $types);

    // Load task_command property from hook_hosting_tasks data.
    $node->task_command = $types[$node->ref_type][$node->task_type]['command'];
Jon Pugh’s picture

Status: Active » Reviewed & tested by the community

Patch in #2 looks best to me.

As helmo said in IRC:

drush_hosting_task_validate() function is creating a node object and directly storing it in a drush context

So we need to handle a missing task_command property.

Let's just add a comment describing why that code is there and it's RTBC.

helmo’s picture

Title: Upgrade to 3.14.0 issue » Upgrade to 3.14.0 issue on a missing task_command property
Status: Reviewed & tested by the community » Needs review

I've pushed #2 but will leave it open to let others double check.

  • helmo committed 15f3ca4 on 7.x-3.x
    Issue #2942500 by helmo: hotfix for missing task_command value
    
helmo’s picture

Status: Needs review » Fixed

Didn't see any problems after this hotfix ... assuming this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.