Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.When a certificate generation fails, the verify task fails but the task still writes the certificate path to the virtualhost file.
This breaks apache, as the virtualhost config is broken, so apache can't reload or start.
We should:
- Only throw a warning if certificate generation fails. The site will still work in this situation, so a warning is more appropriate.
Don't write the certificate file info to virtualhost configs if there isn't one.See #3020747: Don't add SSL config to configuration files if the crt files aren't there/aren't readable. (especially redirects)
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3014468-graceful-fail.patch | 987 bytes | Jon Pugh |











Comments
Comment #3
Jon PughComment #5
Jon PughComment #6
colanTypo?
hosting_https_fail_task_if_certificate_failesShould be "fails"?
Comment #7
helmo CreditAttribution: helmo as a volunteer commentedI think this is a duplicate of #3020747: Don't add SSL config to configuration files if the crt files aren't there/aren't readable. (especially redirects)
Comment #8
Jon PughComment #11
Jon PughComment #12
Jon PughNot quite a duplicate, but did have overlapping results. I removed the changes related to turning off HTTPS/SSL, since that is now handled in #3020747: Don't add SSL config to configuration files if the crt files aren't there/aren't readable. (especially redirects)
The warning option for LE certs is still a good idea, I think.
Comment #13
Jon PughTypos fixed. Ready for review.
Comment #16
Jon Pugh