The branch and push options in the git checkout form are on by default. When you uncheck the branch checkbox it hides the push checkbox ... but it's value is still taken into account. This leads to an error as servers often only have a read-only deploy key.

Changing the default to FALSE seems reasonable, restoring previous behaviour.
But still I think that a submit handler should check for this condition.

CommentFileSizeAuthor
#2 3009104-hosting_git_push.patch1.26 KBhelmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

helmo created an issue. See original summary.

helmo’s picture

Status: Active » Needs review
FileSize
1.26 KB

Here's a draft patch that tries to do both... however the submit hook is working yet.

Jon Pugh’s picture

We can use "#element_validate" to check the value of the other field and force a FALSE value for the push value.

Jon Pugh’s picture

Assigned: Unassigned » Jon Pugh
Status: Needs review » Active

I'll fix.

Jon Pugh’s picture

Status: Active » Needs work

Created a branch.