Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.The branch and push options in the git checkout form are on by default. When you uncheck the branch checkbox it hides the push checkbox ... but it's value is still taken into account. This leads to an error as servers often only have a read-only deploy key.
Changing the default to FALSE seems reasonable, restoring previous behaviour.
But still I think that a submit handler should check for this condition.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3009104-hosting_git_push.patch | 1.26 KB | helmo |











Comments
Comment #2
helmo CreditAttribution: helmo at Initfour websolutions commentedHere's a draft patch that tries to do both... however the submit hook is working yet.
Comment #3
Jon PughWe can use "#element_validate" to check the value of the other field and force a FALSE value for the push value.
Comment #4
Jon PughI'll fix.
Comment #5
Jon PughCreated a branch.