How to reproduce: On a plain Aegir site with hosting_git, create a new platform.

The "Repository URL" (and some other fields) are displayed as read-only, or at least, are missing their input text field.

This appears to be caused by commit 8bbce8b85cd2b510c65427d1b7c819d30f042e4a. If I revert the "if", it works as expected.

Comments

bgm created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Does it work with Aegir Deploy?

If you made that commit a link, it would be easier to review. :)

bgm’s picture

bgm CreditAttribution: bgm commented

Here's a link: https://cgit.drupalcode.org/hosting_git/commit/?id=8bbce8b

I wasn't aware of Hosting Deploy. I'll have a look!

bgm’s picture

bgm CreditAttribution: bgm commented
Issue summary: View changes
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative, DNV GL commented

Removing the '&& isset($node->git['repo_url']' part seems to solve it.... or does that break another usecase?

  • helmo committed 90825d2 on 7.x-3.x 
    Issue #3006600 by bgm, colan, helmo: Regression: cannot enter the Git...
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative, DNV GL commented
Status: Active » Fixed

After discussing with jon in irc I've committed the fix from #5 and reverted the IP that was accidentally removed from the whitelist in the mentioned commit.

See also #2981195: Update IP ranges whitelist for webhook access

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.