I have created platfor using git repo. But during the verification it show a warning message "trim() expects parameter 1 to be string, array given provision_git.drush.inc:458"

CommentFileSizeAuthor
#7 2971666_7_hosting_git_platform_verification_fail.patch745 bytesAbhinand Gokhala K
#2 2971666_hosting_git_platform_verification_fail.patch799 bytesAbhinand Gokhala K
Verify Platform DITT Bhutan GovCMS Live 43 230 208 5.png60.9 KBAbhinand Gokhala K
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Abhinand Gokhala K created an issue. See original summary.

Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
FileSize
2971666_hosting_git_platform_verification_fail.patch799 bytes

I have solved this issue.

Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
Assigned: Abhinand Gokhala K » Unassigned
Status: Active » Needs review
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Needs work

Good catch. Some review:

+++ b/drush/provision_git.drush.inc
@@ -455,7 +455,13 @@ function _provision_git_update_git_meta_data() {
-      $git_ref = trim(str_replace('refs/heads/', '',drush_shell_exec_output()));;
+      $temp_git_ref =  str_replace('refs/heads/', '',drush_shell_exec_output());
+      ¶
+      if(!empty($temp_git_ref) && is_string($temp_git_ref)) {
+        $temp_git_ref = trim($temp_git_ref);
+      }
+
+      $git_ref = $temp_git_ref;

All of this could be shortened to:

$temp_git_ref = str_replace('refs/heads/', '',drush_shell_exec_output());
$git_ref = (!empty($temp_git_ref) && is_string($temp_git_ref)) ? trim($temp_git_ref) : $temp_git_ref;

Other minor things:

  • Extra whitespace on line 460.
  • Space needed after "if", but we no longer need it.
Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented

Yes, Thanks for the replay.

Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
FileSize
2971666_7_hosting_git_platform_verification_fail.patch745 bytes

I did the changes.

Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
Status: Needs work » Needs review
Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented
Issue summary: View changes
Abhinand Gokhala K’s picture

Abhinand Gokhala K CreditAttribution: Abhinand Gokhala K at Zyxware Technologies commented

Is this fine?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Reviewed & tested by the community

Code looks good. It would be great if someone else could test it, but maybe we're okay with the tests we have.

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for DNV GL commented

I noticed the same warning and this patch resolved it.

Committed.

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for DNV GL commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.