Neither the Composer nor Git submodules depend on the base modules, and the base module doesn't depend on either of the submodules. However, it appears as though we should enforce the former.

Assuming the above is true, there shouldn't be a hosting feature for the base module as it's simply a dependency for the other two.

Patch forthcoming, but please correct me if I'm missing something here.

Comments

colan created an issue. See original summary.

  • colan committed 2155590 on 7.x-3.x
    Issue #2930610 by colan: Removed base hosting feature and made it a...
colan’s picture

Status: Active » Needs review
ergonlogic’s picture

Status: Needs review » Reviewed & tested by the community

The base module has hooks to run composer install, which doesn't necessarily require the platform to either be built with Composer, nor cloned from git. Likewise, you may want to build/clone a platform (with the sub-modules), but not run composer install automatically

That said, this patch is reasonable. It just makes it a little less flexible. IIRC, I think I'd intended to add a checkbox somewhere (on the platform form?) that'd allow control over that behaviour. After that, I'd have done something akin to this patch.

Since it's probably 90% of users who will want to run composer install, you can go ahead with your patch, and we can add the form element(s) as a feature down the road.

colan’s picture

Status: Reviewed & tested by the community » Fixed

  • colan committed 396f9fe on 7.x-3.x
    Issue #2930610 by colan: Re-add the base hosting feature as it's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.