If inserting a node with a hosting_context that already exists, hosting_context_register throws an uncaught exception and you get site nodes with no context.

I've come across this condition plenty of times over the years, please let me know if you have too.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'pr123.devshop.whatever.computer' for key 'name': INSERT INTO {hosting_context} (nid, name) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => 23557 [:db_insert_placeholder_1] => 'pr123.devshop.whatever.computer') in hosting_context_register() (line 1201 of /var/aegir/devmaster-github-pr-queue/profiles/devmaster/modules/aegir/hosting/hosting.module).

If something create's a site node and assigns hosting_context property that already exists, an error like the one above will be logged, but the site node will still be created.

It will fail it's install task with Could not find provision alias named: @

The node_save() should fail if a hosting_context record cannot be inserted, yeah?