Issue #2960769: Add proper UX to the selector for choosing logs types to show added a better interface for selecting severity levels (in the 'hosting_task_logs_types_display' variable). However, if we had already configured a value using the old interface, the task log will show as empty.

How to reproduce:

drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'

Then view the task log of an existing task, which will show as empty.

A fix could be to have an upgrade task to convert the old space-delimited string to an array?

CommentFileSizeAuthor
#10 3065477-10-upgrade-variable-task-log-types-display.patch613 bytesmillenniumtree

Comments

bgm created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Sounds reasonable.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Component: Code » User interface
Priority: Normal » Major

Just ran into this myself.

Workaround

  1. Navigate to Administration » Hosting » Settings.
  2. Under Task Logs to Display, check the task types you're interested in.
  3. Hit the Save configuration button.

I'll add a link to here from the release notes.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue summary: View changes
Related issues: +#2960769: Add proper UX to the selector for choosing logs types to show

Release note added.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

We should perhaps add an update hook to change the format of the saved variable.

socialnicheguru’s picture

socialnicheguru commented

thanks for this. I thought my install was broken.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Priority: Major » Critical

Marking critical.

This change shouldn't have been merged without an update hook.

For the record, I tried checkboxes also when I first designed this feature. It didn't really work cleanly because the list can change.

shaneonabike’s picture

shaneonabike commented

Oooh this is a hidden configuration. I also thought my install was broken.. maybe we need this in the docs somewhere too?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

It's in the release notes. See https://docs.aegirproject.org/release-notes/3.18/#known-issues .

millenniumtree’s picture

millenniumtree
he/him
Location Holualoa, HI
commented
Status: Active » Needs review
StatusFileSize
new 3065477-10-upgrade-variable-task-log-types-display.patch613 bytes

Added an update hook to perform the string->array upgrade.

To test the upgrade:

run:
drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'

View any task - the output should be blank.

Apply the patch

Run the drupal updates with:
drush @hm updatedb

View the task again - it should now have output

kienan’s picture

kienan commented

As an aside, would it be worthwhile to leave a message for the user when no outputs are configured / no logs lines match to explain that the reason for an empty screen?

  • helmo committed 16290ac on 7.x-3.x authored by millenniumtree 
    Issue #3065477 by millenniumtree: Task log is empty if severity levels...
helmo’s picture

helmo commented
Status: Needs review » Fixed

Committed with a minimal codestyle fix.

  • helmo committed d5461f0 on 7.x-3.x 
    Issue #3065477 by helmo: Codestyle
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

#11: Sounds like a good idea to me. Feel free to whip something up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.