Issue #2960769: Add proper UX to the selector for choosing logs types to show added a better interface for selecting severity levels (in the 'hosting_task_logs_types_display' variable). However, if we had already configured a value using the old interface, the task log will show as empty.

How to reproduce:

drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'

Then view the task log of an existing task, which will show as empty.

A fix could be to have an upgrade task to convert the old space-delimited string to an array?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bgm created an issue. See original summary.

colan’s picture

Sounds reasonable.

colan’s picture

Component: Code » User interface
Priority: Normal » Major

Just ran into this myself.

Workaround

  1. Navigate to Administration » Hosting » Settings.
  2. Under Task Logs to Display, check the task types you're interested in.
  3. Hit the Save configuration button.

I'll add a link to here from the release notes.

colan’s picture

ergonlogic’s picture

We should perhaps add an update hook to change the format of the saved variable.

SocialNicheGuru’s picture

thanks for this. I thought my install was broken.

Jon Pugh’s picture

Priority: Major » Critical

Marking critical.

This change shouldn't have been merged without an update hook.

For the record, I tried checkboxes also when I first designed this feature. It didn't really work cleanly because the list can change.

ShaneOnABike’s picture

Oooh this is a hidden configuration. I also thought my install was broken.. maybe we need this in the docs somewhere too?

colan’s picture

millenniumtree’s picture

Status: Active » Needs review
FileSize
613 bytes

Added an update hook to perform the string->array upgrade.

To test the upgrade:

run:
drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'

View any task - the output should be blank.

Apply the patch

Run the drupal updates with:
drush @hm updatedb

View the task again - it should now have output

kienan’s picture

As an aside, would it be worthwhile to leave a message for the user when no outputs are configured / no logs lines match to explain that the reason for an empty screen?

  • helmo committed 16290ac on 7.x-3.x authored by millenniumtree
    Issue #3065477 by millenniumtree: Task log is empty if severity levels...
helmo’s picture

Status: Needs review » Fixed

Committed with a minimal codestyle fix.

  • helmo committed d5461f0 on 7.x-3.x
    Issue #3065477 by helmo: Codestyle
    
colan’s picture

#11: Sounds like a good idea to me. Feel free to whip something up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.