Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue #2960769: Add proper UX to the selector for choosing logs types to show added a better interface for selecting severity levels (in the 'hosting_task_logs_types_display' variable). However, if we had already configured a value using the old interface, the task log will show as empty.
How to reproduce:
drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'
Then view the task log of an existing task, which will show as empty.
A fix could be to have an upgrade task to convert the old space-delimited string to an array?
Comment | File | Size | Author |
---|---|---|---|
#10 | 3065477-10-upgrade-variable-task-log-types-display.patch | 613 bytes | millenniumtree |
Comments
Comment #2
colanSounds reasonable.
Comment #3
colanJust ran into this myself.
Workaround
I'll add a link to here from the release notes.
Comment #4
colanRelease note added.
Comment #5
ergonlogicWe should perhaps add an update hook to change the format of the saved variable.
Comment #6
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedthanks for this. I thought my install was broken.
Comment #7
Jon PughMarking critical.
This change shouldn't have been merged without an update hook.
For the record, I tried checkboxes also when I first designed this feature. It didn't really work cleanly because the list can change.
Comment #8
ShaneOnABike CreditAttribution: ShaneOnABike as a volunteer and at Bees on a Bike commentedOooh this is a hidden configuration. I also thought my install was broken.. maybe we need this in the docs somewhere too?
Comment #9
colanIt's in the release notes. See https://docs.aegirproject.org/release-notes/3.18/#known-issues .
Comment #10
millenniumtreeAdded an update hook to perform the string->array upgrade.
To test the upgrade:
run:
drush @hm vset hosting_task_logs_types_display 'error warning info ok success status'
View any task - the output should be blank.
Apply the patch
Run the drupal updates with:
drush @hm updatedb
View the task again - it should now have output
Comment #11
kienan CreditAttribution: kienan commentedAs an aside, would it be worthwhile to leave a message for the user when no outputs are configured / no logs lines match to explain that the reason for an empty screen?
Comment #13
helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commentedCommitted with a minimal codestyle fix.
Comment #15
colan#11: Sounds like a good idea to me. Feel free to whip something up.