I made a preprocess event dispatch module. Could it be possible that I integrate my module with yours?

CommentFileSizeAuthor
#12 preproces_events-2849526-12.patch69.64 KBpdenooijer
#9 preproces_events-2849526-9.patch67.61 KBpdenooijer

Comments

pdenooijer created an issue. See original summary.

robin.ingelbrecht’s picture

robin.ingelbrecht commented

Ofcourse! Maybe you can post the module in this issue so I can review it. If everything looks fine I can make you co-maintainer so you can add and commit the events yourself :)

pdenooijer’s picture

pdenooijer commented

https://www.drupal.org/sandbox/pdenooijer/2841877
My sandbox, take a look :).

robin.ingelbrecht’s picture

robin.ingelbrecht commented

Looks nice and clean! Could you write a patch against the 8.x-1.1 version of this module?
Maybe you can also add an example in the "Example" folder on how to use the events instead of describing it in the readme?
Feel free to update the readme file if necessary.

Once I applied this patch and everything seems to look ok, I will make you maintainer. This way you can fix bugs and commit them and make new releases if necessary. What do you think?

pdenooijer’s picture

pdenooijer commented

Yeah, that sounds awesome! I'll try to make the patch this weekend.

robin.ingelbrecht’s picture

robin.ingelbrecht commented

Ok. Thanks for the contribution :)

pdenooijer’s picture

pdenooijer commented

I'll try to fix it this weekend, bit more work / less time then expected.

robin.ingelbrecht’s picture

robin.ingelbrecht commented

No problem. We're in no pressure to get this done ;)

pdenooijer’s picture

pdenooijer commented
StatusFileSize
new preproces_events-2849526-9.patch67.61 KB

I found some time to finish it and test it extensively with a behat suite. I hope this patch is ok :)!

robin.ingelbrecht’s picture

robin.ingelbrecht commented

I took a very quick look. Am I right you dind't add any examples on how to use the new preprocress events?

pdenooijer’s picture

pdenooijer commented

Aah yeah, forgot that! I'll add a new patch with an example. Thanks for the quick response!

pdenooijer’s picture

pdenooijer commented
StatusFileSize
new preproces_events-2849526-12.patch69.64 KB

I added an example :)!

robin.ingelbrecht’s picture

robin.ingelbrecht commented

I will add the patch later this week. I'll also make you maintainer.
Thanks!

  • pdenooijer authored 2379382 on 8.x-1.x 
    Issue #2849526 by pdenooijer: Preprocess Events
robin.ingelbrecht’s picture

robin.ingelbrecht commented
Status: Active » Fixed

Applied patch and made a new release. Also made you co-maintainer

pdenooijer’s picture

pdenooijer commented

Thanks :)!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.