Installing module on D8.3.3 I got following message:

Warning: htmlspecialchars() expects parameter 1 to be string, object given in Drupal\Component\Utility\Html::escape() (line 423 of core/lib/Drupal/Component/Utility/Html.php).

Just installed honeypot months ago on other site, and got no message like this.

At first look I cant see any other problem

CommentFileSizeAuthor
#8 honeypot-correct-install-message.png78.71 KBgeerlingguy
#6 honeypot-display-install-message-bug.png87.05 KBgeerlingguy
#4 honeypot-broken_configure_link-2885016-4-d8.patch724 byteseelkeblok
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MartinMa created an issue. See original summary.

rhormens’s picture

rhormens CreditAttribution: rhormens at CI&T commented
Assigned: Unassigned » rhormens
eelkeblok’s picture

eelkeblok
him/his
Primary language Dutch
Location Netherlands 🇳🇱
CreditAttribution: eelkeblok at One Shoe commented

Just to save somebody a few minutes of debugging, the problem is the Link object being passed into t() from the hook_install implementation.

eelkeblok’s picture

eelkeblok
him/his
Primary language Dutch
Location Netherlands 🇳🇱
CreditAttribution: eelkeblok at One Shoe commented
Status: Needs work » Needs review
FileSize
honeypot-broken_configure_link-2885016-4-d8.patch724 bytes

I took the liberty of baking a patch. Sorry if I duplicated some of your work, rhormens.

Just as some extra explanation about the patch, it not only changes the type of object passed into t(), but also changes the structure of the translated string. It is generally considerded better to keep linked text in context and only insert the linked url with a placeholder. This makes the translator's job a lot easier.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Needs review » Reviewed & tested by the community

Looks good. I'll merge soon and put out a new release. Thanks!

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
FileSize
honeypot-display-install-message-bug.png87.05 KB

Not only that, the install message looks pretty dumb the way it's currently displaying:

Honeypot install message bug

  • geerlingguy committed d25777c on 8.x-1.x authored by eelkeblok 
    Issue #2885016 by eelkeblok, geerlingguy, MartinMa: htmlspecialchars()...
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Reviewed & tested by the community » Fixed
FileSize
honeypot-correct-install-message.png78.71 KB

Fixed via patch, thanks for everyone's help! The install message looks correct again:

Honeypot successful install message.

rhormens’s picture

rhormens CreditAttribution: rhormens at CI&T commented
Assigned: rhormens » Unassigned
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Title: htmlspecialchars() expects parameter 1 to be string » Fix install message to prevent htmlspecialchars() warning

Updating title for posterity.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.