It would be good for modules that integrate with Honeypot to know what kind of rejection happened with a Honeypot form rejection, so hook_honeypot_reject() should have a third parameter, $type, with either 'honeypot' or 'honeypot_time' passed in.

For the original impetus, see #1969212-11: Add hook_honeypot_reject so other modules can react to rejected form submissions.

CommentFileSizeAuthor
#7 2067221-7-hook-honeypot-reject-d6.patch2.53 KBgeerlingguy
#4 2067221-4-improve-hook-honeypot-reject.patch2.58 KBgeerlingguy
#1 2067221-1-improve-hook-honeypot-reject.patch2.58 KBgeerlingguy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Status: Active » Needs review
FileSize
2067221-1-improve-hook-honeypot-reject.patch2.58 KB

Testbot, go! (I'll need to port this up to D8 and back to D6 as well...).

Also need to make sure this API change is documented in the release node.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Status: Needs review » Patch (to be ported)

I pushed up the patch... but because of #2066525: Pushed git commits and tags are delayed, unable to create release nodes, it's not yet showing up anywhere correctly :(

To be done:

  • Port patch to D8.
  • Port patch to D6.
  • Make sure to document the API change in the next release's release notes!
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

Okay, porting to D8 next... commit is finally showing up: http://drupalcode.org/project/honeypot.git/commit/272de49

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Status: Patch (to be ported) » Needs review
FileSize
2067221-4-improve-hook-honeypot-reject.patch2.58 KB

Will let a testbot check it out.

Status: Needs review » Needs work

The last submitted patch, 2067221-4-improve-hook-honeypot-reject.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Version: 8.x-1.x-dev » 6.x-1.x-dev
Status: Needs work » Patch (to be ported)

Testbot failure was due to something unrelated; fixed with this commit: http://drupalcode.org/project/honeypot.git/commit/9a45267

I've finished the patch for 8.x, and committed it here: http://drupalcode.org/project/honeypot.git/commit/81baf3a

Next step is D6.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Status: Patch (to be ported) » Needs review
FileSize
2067221-7-hook-honeypot-reject-d6.patch2.53 KB

So, apparently I never added hook_honeypot_reject to Drupal 6. Doing so with the attached patch.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Resetting tags, and fixed in D6 with this commit: http://drupalcode.org/project/honeypot.git/commit/5a83f75

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.