New feutures: Do not repeat nodes, seperate number for Related and Recommended. No restriction in number of nodes to show. [#758268]

Hi Guys

I'm loving this module and did some mods to it that I hope get commited:

1. Make use of a test function (fourth parameter in recommender_top_prediction() ) to check whether to show a node or not. In this case I check if the node is being shown in the page already, and if it is, it gets excluded. The reason I do this is because every node is shown wrapped in a DIV with a unique ID "node-#". Hence, if the node has been shown we do not want to repeat the ID AND also because if we show a node twice in a page, we loose a chance to show a different product.

2. Separate in the setting page the number of nodes to show in "related" block and in "recommended" block

3. Number of nodes to show is now a text box, maximum 2 digits, and it validates to see if it is numeric, and converts whatever you input to an integer - in case you decide to set 0.8 :P

Love to all

Federico

Comment	File	Size	Author
#2	history_rec-6.x-1.1.patch	6.65 KB	jm.federico

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jm.federico CreditAttribution: jm.federico commented 31 March 2010 at 12:29

WAIT, patch incomplete

I'm looking for some code that left out of it and will repost!!!

Comment #2

jm.federico CreditAttribution: jm.federico commented 31 March 2010 at 12:36

File	Size
history_rec-6.x-1.1.patch	6.65 KB

Here it is, ignore the previous patch. Was missing some code

Keep in mind that I use HOOK_nodeapi to count the nodes that have been viewed. Do not know if there is a more efficient way of doing it. If there is please let me know.

I'm using this in an online store with medium traffic on a dreamhost shared account, and works no problems.

Comment #3

jm.federico CreditAttribution: jm.federico commented 31 March 2010 at 14:10

hum a friend asked me how in hell you might have a node more than once showing on a page with this module.
Well, it will happen if you have more modules showing content. I for example, have this module, and also have the ubercart product recommender. PLUS we have some nodes that we show arbitrarily (for whatever reason, might be discounted? or special product of the week, or whatever) and we show them all as nodes.

Federico

Comment #4

danithaca CreditAttribution: danithaca commented 31 March 2010 at 12:56

@jm.dederico: great! thanks. i'll look at the patch and apply it soon. btw, may i acknowledge your contribution in the readme.txt file?

Comment #5

jm.federico CreditAttribution: jm.federico commented 31 March 2010 at 13:04

@danithaca

Actually that would be awesome.
If you can put my website I would love it
federicojm.com (it is quite empty right now :( but one day I'll take the time to make it good)

I'm glad I can help ;)

Cheers

Comment #6

jm.federico CreditAttribution: jm.federico commented 20 August 2010 at 13:26

Status:

Active

» Needs review

Hello

Was doing some clean-up on my issues listing, was wondering it you have had time to check and commit.

Comment #7

danithaca CreditAttribution: danithaca commented 13 September 2010 at 20:17

@jm.federico: would you please create a CVS account. I'm trying to add you as co-maintainer, if you think it's fine. Also, please credit yourself as co-maintainer in the readme file as well :)