take "accesslog" as browsing history input (6.x) [#509846]

Comment	File	Size	Author
#17	history_rec.admin_.inc_.txt	5.07 KB	colinchan
#17	history_rec.module.txt	8.08 KB	colinchan
#7	history_rec admin.txt	5.55 KB	Ankit22
#5	history_rec admin.txt	5.41 KB	Ankit22
#2	history_rec.admin_.txt	4.13 KB	Ankit22
#1	history_rec-accesslog.patch	4.47 KB	JoeMcGuire

Comment #1

JoeMcGuire CreditAttribution: JoeMcGuire commented 22 April 2010 at 14:47

File	Size
history_rec-accesslog.patch	4.47 KB

Accesslog table support

I’ve added support for the accesslog table

If the statistics module is enabled site administrators can then choose between the history and accesslog table.

The advantages of the accesslog table

Control over how long records are kept
Also records anonymous user traffic

Log in or register to post comments

Comment #2

Ankit22 CreditAttribution: Ankit22 commented 29 July 2010 at 06:59

File	Size
history_rec.admin_.txt	4.13 KB

I just want to know weather the way i have implemented this patch is correct or not?

thanks

Log in or register to post comments

Comment #3

JoeMcGuire CreditAttribution: JoeMcGuire commented 29 July 2010 at 08:48

Doesn't appear to be. let me know if it's something I need to look at.

Log in or register to post comments

Comment #4

Ankit22 CreditAttribution: Ankit22 commented 29 July 2010 at 11:15

Can you tell me how to fix it?

or whats the problem?

thanks

Log in or register to post comments

Comment #5

Ankit22 CreditAttribution: Ankit22 commented 29 July 2010 at 12:24

File	Size
history_rec admin.txt	5.41 KB

I tried implementing it again...
can you have a look ...

thanks

Log in or register to post comments

Comment #6

JoeMcGuire CreditAttribution: JoeMcGuire commented 29 July 2010 at 12:47

That looks like a winner

Log in or register to post comments

Comment #7

Ankit22 CreditAttribution: Ankit22 commented 29 July 2010 at 12:53

File	Size
history_rec admin.txt	5.55 KB

When i used this file mysite's /admin/settings/history_rec page went blank ... i guess some formatting trouble

Log in or register to post comments

Comment #8

Ankit22 CreditAttribution: Ankit22 commented 29 July 2010 at 13:09

that page is giving me a blank page ... can you tell me what are "-" signs in that file and
For example have a look at the following piece of code from ur patch

- function _history_rec_wrap_each(&$item) {
- $item = "'$item'";
+ switch(variable_get('history_rec_source', 'history')) {
+ case 'accesslog':
+ return history_rec_run_recommender_accesslog();
+ break;
+ default: // history table
+ return history_rec_run_recommender_history();
+ break;
}
+}
+

Now what does - means before that function

also

diff -upN ../old/history_rec/history_rec.module ./history_rec.module
--- ../old/history_rec/history_rec.module 2009-09-21 20:17:12.000000000 +0100
+++ ./history_rec.module 2010-04-22 14:47:32.000000000 +0100
@@ -111,11 +111,19 @@ function history_rec_run_recommender() {
if (empty($enabled_types)) {
return;
}

do the above mentioned piece of code needs to be added ...

thanks for quick response joeMcGuire

it would be gr8 help if you can explain anything from above mentioned queries.

Log in or register to post comments

Comment #9

danithaca CreditAttribution: danithaca commented 29 July 2010 at 13:09

Sorry guys. I'm pretty occupied with daily work these days. Will take a look on the patch when I've got time.

Log in or register to post comments

Comment #10

Ankit22 CreditAttribution: Ankit22 commented 3 September 2010 at 13:23

I have been waiting for long ... still got no result :(

Log in or register to post comments

Comment #11

danithaca CreditAttribution: danithaca commented 13 September 2010 at 20:20

@Ankit22, JoeMcGuire: May I ask you to be co-maintainers of the module? I'll focus my attention on improving the RecAPI module and might not be able to work on this module soon. Thanks. (http://michiza.com/blog/roadmap-recommender-api-module-and-helper-modules).

Log in or register to post comments

Comment #12

jm.federico CreditAttribution: jm.federico commented 16 October 2010 at 07:43

Status:

Active

» Needs review

Hi Guys

I'm co-maintaining this module now.

@Ankit22, read http://drupal.org/node/367392 for info about patches

@JoeMcGuire, are you using this module on a live site with your patch? Would like to know how it is working.

Cheers

Log in or register to post comments

Comment #13

Ankit22 CreditAttribution: Ankit22 commented 24 November 2010 at 13:28

I would love to. I have sent you a mail regarding the same.

Log in or register to post comments

Comment #14

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno commented 29 November 2010 at 22:19

FYI, Ankit22 is now co-maintainer of this project.

Log in or register to post comments

Comment #15

danithaca CreditAttribution: danithaca commented 15 July 2011 at 13:18

Version:	6.x-1.0-beta1	» 7.x-1.0-alpha1
Status:	Needs review	» Active

@ JoeMcGuire: Thanks for your patch. I can add you as as co-maintainer if you like to.
@Ankit22: I have added you as co-maintainer for the module. If you want to commit your patch, please do so on the 6.x-1.x release.

I'll add accesslog as a feature for 7.x-1.x release. Make the status as "active" for that.

Log in or register to post comments

Comment #16

JoeMcGuire CreditAttribution: JoeMcGuire commented 15 July 2011 at 14:19

Hi Guys,

Sorry i wrote this patch for a project I'm not involved in any more. I'll let you know if I pick it up again but no plans to at the moment.

Log in or register to post comments

Comment #17

colinchan CreditAttribution: colinchan commented 19 July 2011 at 22:17

Version:

7.x-1.0-alpha1

» 6.x-1.4

File	Size
history_rec.module.txt	8.08 KB
history_rec.admin_.inc_.txt	5.07 KB

Based on the patch submitted by JoeMcGuire, these are the updated files as applied to the 6.x-1.4 release, with a minor spelling tweak that was bothering me (changing "Aviod duplicate results" to "Avoid duplicate results"). From initial testing, it seems to work as expected.

Thanks Joe and Daniel!